Vanilla Item Acquisition and Rolling

[CollinHerber]

Something I feel important to the mod is that we allow all vanilla items to be obtained and crafting the same way or at least some similar way so people can enjoy those and our items. Taking things away that are the base game is a feels bad.

So with that in mind I want to start a discussion around vanilla items and how we want to handle them.

My first thoughts are we somehow tap into the normal drops and have them roll like any other PoT item does.
These items just won't have a "base" to them and won't inherit the implicits nor alt use systems but will be able to roll the affixes that are associated to their gear.

Will these be accomplishable without needing to clone each of the items and have them base off of PoTItem?

Looking for some input from the smarter Tmod brains here.

[GabeHasWon]

The way the current system is written, we would require making mod items that mimic the vanilla item but as a PoTItem. We could refactor the system to store affixes, alt uses and any other relevant data on a GlobalItem, which would save us from needing to make new versions of every item...but that's also a pretty large rewrite. I'd say making PoTItem clones of vanilla items is easier and not notably worse (or better) than rewriting the whole system.
We already have the PoTItem alternative system:

GearAlternatives.Register(moddedItemType, vanillaItemType);

so making these would be pretty trivial. Most vanilla items are "sword" or "gun" too, and all unique functionality is usually on projectiles or similar that is easily re-usable.

[CollinHerber]

Lets take a very basic example such as the Ash Wood Sword

I would imagine that we wouldn't want this to drop as apart of the normal "Gear" but we could base it from the Sword class so it gets the alt use + the normal stats of the item.

Would we then just set the drop rate to 0f and then add the recipes manually? Wouldn't that result in a TON of code?
Is there a way to copy the recipes as well to reduce that?

[GabeHasWon]

We could almost certainly make like, a VanillaClone class, child to PoTItem, that automatically copies the recipes and stats of the original item. Drop rate to 0f also is correct, that's how the Grimoire's materials will work.

So, roughly, an item would just be this:

public class AshSword : VanillaClone
{
    public override CloneId => ItemID.AshSword;
}

With the option for autoloading en-masse for items and whitelisting & manually programming the few items that need it.

[benj7126]

...
If we had a variable of the type Item, that if null just makes the item with the field a PoT item but if it's not null then we redirect most method to the corresponding Item drawing, ai and such; would that work?

[benj7126]

Or rather, make it a subclass, so no behavior if it's null...

[GabeHasWon]

Where would this be? If this is in a GlobalItem, it'd be similar to but generally more work than my VanillaClone item proposal, since we'd have to manually reroute all methods into the instance.

[benj7126]

Yeah, looking at it idk where i was going with this 🤷
(forgot that the difference between an item and moditem is like that of water and sky...) <- thats totally me trying to translate a saying/proverb from my native language to english... no wonder it sounded dumb...