-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
player should pass the tests on playerjs.io #236
Comments
Yes, we do. Let us implement the player.js specs : https://github.com/embedly/player.js/blob/master/SPEC.rst We need to do this anyway for #178 . |
Hi player.refactor dream team!
is it good for you? |
a possibile flow could be: var player = new Paratiiplayer(); |
ref #175 |
using gateway:
without gateway:
|
Any updates on this? Especially regarding "make player,js and player.html driven by video tag states/events ( video tag wiil be our source of truth) @eliawk"? |
Actually i've done a fast refactor in order to fix binding issues. There's still some work to do. |
for the records http://clappr.io/ |
It seems to me we are trackign two separate things in this issue: (1) does our player play nice with playerjs.io and (2) shoudl we refactor, and how? I'm opening a new issue for (2), and will rename this one. |
Developing related videos at video playback ended I've noticed that we need a hook/events-watcher approach. For example playing, pause, ended, replaying are not well centralized/binded and sometimes there is discordance between frontend and player states.
The text was updated successfully, but these errors were encountered: