Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player should pass the tests on playerjs.io #236

Open
geckoslair opened this issue Nov 6, 2017 · 9 comments
Open

player should pass the tests on playerjs.io #236

geckoslair opened this issue Nov 6, 2017 · 9 comments

Comments

@geckoslair
Copy link
Member

Developing related videos at video playback ended I've noticed that we need a hook/events-watcher approach. For example playing, pause, ended, replaying are not well centralized/binded and sometimes there is discordance between frontend and player states.

@jellegerbrandy
Copy link
Contributor

jellegerbrandy commented Nov 9, 2017

Yes, we do.

Let us implement the player.js specs : https://github.com/embedly/player.js/blob/master/SPEC.rst
This seems somethign relatively easy to do using adapters https://github.com/embedly/player.js#adapters

We need to do this anyway for #178 .

@geckoslair geckoslair self-assigned this Nov 9, 2017
@geckoslair geckoslair changed the title player.js need a refactor player.js needs a refactor Nov 9, 2017
@ya7ya ya7ya self-assigned this Nov 9, 2017
@geckoslair
Copy link
Member Author

geckoslair commented Nov 9, 2017

Hi player.refactor dream team!
This issue in composed by three subissues:

  • make player,js and player.html driven by video tag states/events ( video tag wiil be our source of truth) @eliawk
  • make all the library that's interact with the video tag binded to the video tag and not to meteor instace @ya7ya
  • make a library that binds player.js (the library required by embedly) with our video tag @geckoslair

is it good for you?

@geckoslair
Copy link
Member Author

a possibile flow could be:

var player = new Paratiiplayer();
yahyamagicfunctions(player)
playerJSadapter(player)

@geckoslair
Copy link
Member Author

ref #175

@geckoslair
Copy link
Member Author

@jellegerbrandy
Copy link
Contributor

Any updates on this? Especially regarding "make player,js and player.html driven by video tag states/events ( video tag wiil be our source of truth) @eliawk"?

@geckoslair
Copy link
Member Author

Actually i've done a fast refactor in order to fix binding issues. There's still some work to do.

@eliawk
Copy link
Collaborator

eliawk commented Nov 17, 2017

for the records http://clappr.io/

@jellegerbrandy
Copy link
Contributor

It seems to me we are trackign two separate things in this issue: (1) does our player play nice with playerjs.io and (2) shoudl we refactor, and how?

I'm opening a new issue for (2), and will rename this one.

@jellegerbrandy jellegerbrandy changed the title player.js needs a refactor player should pass the tests on playerjs.io Nov 22, 2017
@felipegaucho felipegaucho mentioned this issue Nov 26, 2017
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants