-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow an on_update
as well as a _RecordUpdater
#121
Comments
I added that as defensive code in case we ever do use it. If someone were to use it they would likely have an unexpected result, as the code would break in an unrelated place. I'm ok with removing it as long as this sort of protection is still available; if we change how the RecordUpdater is created/passed that will probably handle it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
PandABlocks-ioc/src/pandablocks_ioc/ioc.py
Lines 663 to 682 in 8e25d64
A record updater is created to send data back to the panda.
on_update_name
so this should be removed.record_updater
, which can be merged with the passed inon_update
.on_update
which aren't_RecordUpdater.update
s to also be given a_RecordUpdater
.The text was updated successfully, but these errors were encountered: