Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples/vpc_peering_common_dual_stack): IPv4/IPv6 dual stack architecture example #42

Merged
merged 11 commits into from
Oct 4, 2024
Merged

feat(examples/vpc_peering_common_dual_stack): IPv4/IPv6 dual stack architecture example #42

merged 11 commits into from
Oct 4, 2024

Conversation

pavelrn
Copy link
Contributor

@pavelrn pavelrn commented Sep 18, 2024

Description

Introduce IPv4/IPv6 dual stack VPC peering Common architecture example.

Motivation and Context

IPv6 might used for connectivity in the enterprise network. Because VM-Series is a part of the network, the deployment must support IPv6.

Closes #21, #3.

How Has This Been Tested?

  • Example Terraform plan -> apply -> destroy.
  • ping/ ping6 tests for outbound traffic.

Screenshots (if appropriate)

n/a

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@pavelrn pavelrn requested a review from a team as a code owner September 18, 2024 18:24
@pavelrn pavelrn linked an issue Sep 18, 2024 that may be closed by this pull request
IPv6 example to cover the vpc_peering_common architecture #21
Closed
@pavelrn pavelrn self-assigned this Sep 18, 2024
@pavelrn pavelrn added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 18, 2024
@pavelrn pavelrn requested a review from horiagunica September 24, 2024 12:19
michalbil
michalbil reviewed Oct 3, 2024
View reviewed changes
examples/vpc_peering_common_dual_stack/main.tf Outdated Show resolved Hide resolved
examples/vpc_peering_common_dual_stack/main.tf Outdated Show resolved Hide resolved
examples/vpc_peering_common_dual_stack/main.tf Outdated Show resolved Hide resolved
examples/vpc_peering_common_dual_stack/main.tf Outdated Show resolved Hide resolved
@pavelrn pavelrn dismissed horiagunica’s stale review October 3, 2024 11:17

Fixed as per suggestion

horiagunica
horiagunica approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@horiagunica horiagunica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 👍

@pavelrn pavelrn merged commit 7ae2526 into main Oct 4, 2024
17 checks passed
@pavelrn pavelrn deleted the feature/ipv6-examples-vpc-peering-common-dual-stack branch October 4, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalbil michalbil michalbil left review comments

@horiagunica horiagunica horiagunica approved these changes

Assignees

@pavelrn pavelrn

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPv6 example to cover the vpc_peering_common architecture
3 participants
@pavelrn @horiagunica @michalbil