-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting work on uuid based services #116
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… previous commands over
wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple things that differ with this implementation than the address object implementation.
[Within Location]
Location.Xpath()
function takes three params instead of two; the third parameter being a UUID to use for XPATH purposes instead of the name.[Within Entry]
Entry.Field()
shows how an implementation of retrieving a field from a sub-struct could look like.Entry.SpecMatches()
shows how an implementation of sub-struct matching could look like.Entry.DisableServerResponseInspection
is a flat param with other params but in the XPATH is actually nested within anOptions
section in the XML.LogEnd
param requires a custom UnmarshalXML, and the generator needs to be able to do this.Entry.DisableInspect
param should result in a second versioned object when this output from the generator.Entry.Targets
is a unique type that any rule in the Policy section will have, so we'll need the generator to be able to handle this param type.[Within service.go]
Service.ReadGroup()
/Service.ConfigureGroup()
/Service.DeleteGroup()
.ConfigureGroup()
can be improved to minimize the number of moves needed to end at the desired configuration. Note that only rules in the group given should be moved so as not to cause configuration drift of other group resources.ConfigureGroup()
- it does two multi-config commands currently, at most: one to update the rule specs themselves and one to do the rule movements. It should be technically possible to combine this into a single multi-config, but it will require careful attention to later parts of the code if thelisting
will be updated in place.I might be missing some other callouts, and this is still missing stuff, such as rule hit count handling, so it's not completely finalized, but it's worth checking out where things stand so far.