Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(validation): Improve validation option in Panorama #111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pimielowski
Copy link

@pimielowski pimielowski commented Oct 11, 2023

Motivation and Context

We need to create solution based on validate function in Panorama, and current state of the function can only work in full mode without opportunity to pass option like commit function.

How Has This Been Tested?

I've done local make test plus I test it with example code

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@welcome-to-palo-alto-networks

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@pimielowski
Copy link
Author

@shinmog can you look at this PR? I'm not sure about type

@pimielowski pimielowski changed the title (feature/validation): Improve validation option in Panorama feature(validation): Improve validation option in Panorama Nov 14, 2023
Copy link

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants