Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend service template #50

Merged
merged 9 commits into from
Apr 9, 2024
Merged

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Apr 8, 2024

Description

PR delivers changes from second bullet in #48:

  • refactored template for service.go
  • changes in template for location.go (prepare to use uuid)
  • extension of example used to communicate with firewall
  • fixes in security policy rule spec file for problems found while testing with firewall
  • improvements in functions used in templates rendering

Motivation and Context

#48

How Has This Been Tested?

Code was tested by unit tests and by generating pango and configuring firewall.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech marked this pull request as ready for review April 8, 2024 15:00
@sebastianczech sebastianczech merged commit d5efaa8 into main Apr 9, 2024
8 checks passed
@sebastianczech sebastianczech deleted the extend-service-template-48 branch April 9, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants