Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Compound Triggers / Filters #48

Open
stiesssh opened this issue Jul 31, 2024 · 0 comments
Open

Refactor Compound Triggers / Filters #48

stiesssh opened this issue Jul 31, 2024 · 0 comments
Assignees

Comments

@stiesssh
Copy link
Contributor

stiesssh commented Jul 31, 2024

Follow up issue for #30.

As described in #30, the current mindset regarding compound filter is like this:

Mindset: a CompoundFilter is also a FilterChain i.e when using compound triggers, we get tiny filter chains inside our topmost filterchain, which consist of targetgroup checker, trigger checker, constraint checker etc.
Thus, we must/can rely on the filter operations next and disregard to realize the OR and AND filters.

In #30, we attempted to implement an Triggerchecker filter for the compound OR Trigger, while sticking to the current design. In the end, the presented solution works, but violated the (implicit) contracts of the FilterChain class.

Thus, we want to refactor the Triggerchecker for the compound triggers, such that they do not extend the FilterChain class.

Goal

  1. come up with a reasonable design
  2. implement the solution

Pitfalls resp. things to keep in mind.

  • Compound Triggers can be nested, i.e. we can have a compound OR-Trigger nested into an AND-Trigger, nested into an OR-Trigger and so on.
  • Currently, logical operators AND, OR and XOR are supported by SPD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant