From 6b71af971b22909bd0a79f4b9859a702a75c0db3 Mon Sep 17 00:00:00 2001 From: adithya Date: Sat, 23 Nov 2024 08:31:21 +0530 Subject: [PATCH 1/3] Added checklist to PR template --- .github/pull_request_template.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2672715df..c25d2558b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,7 +4,7 @@ This section can be deleted after reading. We employ the following branching strategy to simplify the development process and to ensure that only stable code is pushed to the `master` branch: - `develop`: For unstable code: New features and bug fixes. -- `master`: Where the stable production ready code lies. Only security related bugs. +- `master`: Where the stable production-ready code lies. Only security-related bugs. NOTE!!! @@ -27,6 +27,9 @@ Fixes # +- [ ] Tests are written for all changes made in this PR. +- [ ] Test coverage meets or exceeds the current coverage (~90/95%). + **Snapshots/Videos:** @@ -44,6 +47,10 @@ Fixes # +**Checklist for Repository Standards** +- [ ] Have you implemented all relevant `coderaabbitai` suggestions? +- [ ] Have you ensured that the PR aligns with the repository’s contribution guidelines? + **Other information** From 55e78b8eb2c81f1fcbfda6630235a0d6812cd7a7 Mon Sep 17 00:00:00 2001 From: adithya Date: Sat, 23 Nov 2024 08:53:00 +0530 Subject: [PATCH 2/3] Updated contributing docs --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cd3339781..4abd4d8d0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -250,6 +250,8 @@ The value of `safeBlockVertical` and `safeBlockHorizontal` will be displayed in - All your file should contain at max `300` lines of code. - Follow proper code formatting and run `flutter format .` before your PR. - Run `flutter analyze` before your PR and make sure to resolve all the found issues. + - Tests must be written for all code changes, ensuring they maintain or exceed the current code coverage threshold. + - Ensure your pull request is approved by Coderaabbitai by addressing and implementing all its suggestions. ### Project Structure From 767b0d22f44a71a7895533b5b82d2e769f544bf6 Mon Sep 17 00:00:00 2001 From: adithya Date: Sat, 23 Nov 2024 09:04:19 +0530 Subject: [PATCH 3/3] Added proper markdown syntax --- .github/pull_request_template.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index c25d2558b..563df3116 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -15,46 +15,46 @@ ONLY SUBMIT PRS AGAINST OUR `DEVELOP` BRANCH. THE DEFAULT IS `MAIN`, SO YOU WILL Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. --> -**What kind of change does this PR introduce?** +### What kind of change does this PR introduce? -**Issue Number:** +### Issue Number: Fixes # -**Did you add tests for your changes?** +### Did you add tests for your changes? - [ ] Tests are written for all changes made in this PR. - [ ] Test coverage meets or exceeds the current coverage (~90/95%). -**Snapshots/Videos:** +Snapshots/Videos: -**If relevant, did you update the documentation?** +### If relevant, did you update the documentation? -**Summary** +### Summary - + -**Does this PR introduce a breaking change?** +### Does this PR introduce a breaking change? -**Checklist for Repository Standards** -- [ ] Have you implemented all relevant `coderaabbitai` suggestions? +### Checklist for Repository Standards +- [ ] Have you reviewed and implemented all applicable `coderaabbitai` review suggestions? - [ ] Have you ensured that the PR aligns with the repository’s contribution guidelines? -**Other information** +### Other information -**Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa/blob/master/CONTRIBUTING.md)?** +### Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa/blob/master/CONTRIBUTING.md)?