Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the geolocator and geocoding packages again #2438

Closed
palisadoes opened this issue Mar 23, 2024 · 1 comment · Fixed by #2439
Closed

Remove the geolocator and geocoding packages again #2438

palisadoes opened this issue Mar 23, 2024 · 1 comment · Fixed by #2439
Assignees
@varshith257
Labels
feature request good first issue Good for newcomers

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Mar 23, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

We are not using the geolocator or the geocoding packages in the code base, yet we have it in our package definitions

Describe the solution you'd like

  1. Remove geolocator if unused
  2. Remove geocoding if unused
  3. No other functionality must be affected
  4. All tests must pass and be valid

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • N/A

Additional context

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Mar 23, 2024
@palisadoes palisadoes changed the title Remove the geolocator package again Remove the geolocator and geocoding packages again Mar 23, 2024
@palisadoes palisadoes added the good first issue Good for newcomers label Mar 23, 2024
@varshith257
Copy link
Member

@palisadoes I have fixed them. Please assign this issue to me

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Mar 23, 2024
@varshith257 varshith257 mentioned this issue Mar 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varshith257 varshith257

Labels
feature request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed the geolocator and geocoding packages varshith257/talawa
2 participants
@palisadoes @varshith257