Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation and confirmation on comments. #2277

Closed
bhoomikshetty opened this issue Dec 28, 2023 · 9 comments · Fixed by #2349
Closed

No validation and confirmation on comments. #2277

bhoomikshetty opened this issue Dec 28, 2023 · 9 comments · Fixed by #2349
Assignees
Labels
bug Something isn't working

Comments

@bhoomikshetty
Copy link

bhoomikshetty commented Dec 28, 2023

Describe the bug
Users are able to comment blank texts.

To Reproduce
Steps to reproduce the behavior:

  1. Enter the comments view.
  2. Without typing anything, hit 'send'.

Expected behavior

  1. Should not allow sending the comment if the comment is empty.
  2. Should provide confirmation once comment is successfully uploaded.

Actual behavior
Clicking 'send' is calling the API with empty comment message and adding the blank comment locally.
After an error is received from the backend, the comment disappears.
This leads to a poor user experience.

Can I work on this issue?

@bhoomikshetty bhoomikshetty added the bug Something isn't working label Dec 28, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Dec 28, 2023
Copy link

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@bhoomikshetty bhoomikshetty changed the title No validation on comments. No validation and confirmation on comments. Dec 28, 2023
@Cioppolo14
Copy link
Contributor

@bhoomikshetty Please use the issue template.

@bhoomikshetty
Copy link
Author

@bhoomikshetty Please use the issue template.

Sorry, updated now.

@palisadoes
Copy link
Contributor

palisadoes commented Dec 28, 2023

Why is this required? No other platform I can think of has confirmation of comments validation.

Confirmation is the comment itself

If there is no content, then the send button shouldn't activate.

Is this the current methodology?

@Azad99-9
Copy link
Contributor

Azad99-9 commented Dec 28, 2023

@palisadoes currently the send button is working even if the comment is blank.

@bhoomikshetty instead of confirming the comment you could just make the send button not work as suggested by palisadoes, in case of blank comment.

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved, needs to be triaged label Dec 29, 2023
@Cioppolo14
Copy link
Contributor

@bhoomikshetty I recommended making changes based on @palisadoes' comment and question.

@bhoomikshetty
Copy link
Author

Why is this required? No other platform I can think of has confirmation of comments validation.

Confirmation is the comment itself

If there is no content, then the send button shouldn't activate.

Is this the current methodology?

That's my bad, I meant to say confirmation after the comment is sent.

Something like this.
Screenshot_20231229_125200.jpg

Copy link

github-actions bot commented Jan 9, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 9, 2024
@noman2002 noman2002 removed the no-issue-activity No issue activity label Jan 22, 2024
@Dante291
Copy link
Contributor

@noman2002 @Cioppolo14 i would like to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
6 participants