-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No validation and confirmation on comments. #2277
Comments
Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues. |
@bhoomikshetty Please use the issue template. |
Sorry, updated now. |
Why is this required? No other platform I can think of has confirmation of comments validation. Confirmation is the comment itself If there is no content, then the send button shouldn't activate. Is this the current methodology? |
@palisadoes currently the send button is working even if the comment is blank. @bhoomikshetty instead of confirming the comment you could just make the send button not work as suggested by palisadoes, in case of blank comment. |
@bhoomikshetty I recommended making changes based on @palisadoes' comment and question. |
That's my bad, I meant to say confirmation after the comment is sent. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
@noman2002 @Cioppolo14 i would like to work on this |
Describe the bug
Users are able to comment blank texts.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Actual behavior
Clicking 'send' is calling the API with empty comment message and adding the blank comment locally.
After an error is received from the backend, the comment disappears.
This leads to a poor user experience.
Can I work on this issue?
The text was updated successfully, but these errors were encountered: