Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ImageService #2259

Closed
literalEval opened this issue Dec 19, 2023 · 1 comment · Fixed by #2265
Closed

Create ImageService #2259

literalEval opened this issue Dec 19, 2023 · 1 comment · Fixed by #2265
Assignees
@Azad99-9
Labels
feature request

Comments

@literalEval
Copy link
Member

Since image uploads and edits are supposed to be functional soon, it would be better if we create a dedicated ImageService for the same. Doing so right now will help us in following SOLID principles and ease PR management in the future.

For now, convertToBase64 can be moved from EditProfilePageViewModel
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Dec 19, 2023
@Azad99-9
Copy link
Contributor

@noman2002 @Cioppolo14 @Kevoniat please assign this issue to me.

@Cioppolo14 Cioppolo14 added feature request and removed unapproved Unapproved, needs to be triaged labels Dec 19, 2023
This was referenced Dec 21, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Azad99-9 Azad99-9

Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create ImageService
3 participants
@Cioppolo14 @literalEval @Azad99-9