Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's possible to create an event with duration of zero seconds #2194

Closed
palisadoes opened this issue Dec 1, 2023 · 3 comments · Fixed by #2206
Closed

It's possible to create an event with duration of zero seconds #2194

palisadoes opened this issue Dec 1, 2023 · 3 comments · Fixed by #2206
Assignees
@bhav-khurana
Labels
bug Something isn't working

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 1, 2023 •
edited
Loading

Describe the bug

It is possible to create an event with zero seconds

To Reproduce
Steps to reproduce the behavior:

  1. Start app
  2. Click on events
  3. Add an event
  4. There will be a default time duration of zero seconds

Expected behavior

  • There should be a reasonable non zero default time duration, say 30 minutes.
  • The duration must work correctly when the event spans multiple days. (eg. A New Year's Eve party)
  • It must be impossible to create an event with a negative duration

Actual behavior

  • Zero second duration events are possible

Screenshots

Additional details

  • You must get the test code coverage up to 100% for any edited files.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship #359
@palisadoes palisadoes added the bug Something isn't working label Dec 1, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Dec 1, 2023
@bhav-khurana
Copy link
Contributor

@palisadoes I would like to work on this issue.. can you please assign it to me?

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Dec 3, 2023
@bhav-khurana
Copy link
Contributor

@palisadoes Should I set the minimum duration of an event to 30 min? Or is it just a default duration?

@palisadoes
Copy link
Contributor Author

  1. Set the default to 30 minutes.
  2. I looked at Google Calendar which allows zero minute meetings. So we should allow that based on the precedent.

@bhav-khurana bhav-khurana mentioned this issue Dec 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhav-khurana bhav-khurana

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add default event duration to 30 min and allow zero minute events
2 participants
@palisadoes @bhav-khurana