Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic error in talawa_plugin_provider.dart file for the visibility of a plugin. #2141

Closed
Dante291 opened this issue Nov 26, 2023 · 1 comment · Fixed by #2168
Closed

Logic error in talawa_plugin_provider.dart file for the visibility of a plugin. #2141

Dante291 opened this issue Nov 26, 2023 · 1 comment · Fixed by #2168
Assignees
Labels
bug Something isn't working

Comments

@Dante291
Copy link
Contributor

Dante291 commented Nov 26, 2023

Describe the bug
There is a logic error in this file.

Screenshot 2023-11-26 234224

In this code, condition plugin["installedOrgs"].contains(userConfig.currentOrg.id) as bool` is never getting checked.

This could be fixed with this logic:

Screenshot 2023-11-26 235223

This will check both conditions i.e. whether Plugin is installed or plugin is already installed in the specific organization and determine the visibility of the Plugin.

@Dante291 Dante291 added the bug Something isn't working label Nov 26, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Nov 26, 2023
@Dante291
Copy link
Contributor Author

@noman2002 Its a quick fix, lemme do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants