-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incoherent Toggle button with light and dark mode #926
Comments
Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues. |
We are now focusing on three types of issues as priority areas:
We will only be accepting feature issues for deficiencies that are obviously lacking in the apps. These are things that make it very difficult to operate the apps. Even so, the PRs will still require you to understand testing as stated before. Cosmetic changes that require only a few lines of code, or relate to screen sizes unlikely to be used are not acceptable under this policy. Closing |
Is your feature request related to a problem? Please describe.
The toggle button on the website is not aligned with the theme it represents. For example:
When the default theme is light, the toggle button incorrectly shows a sun icon (instead of a moon).
When the theme is dark, the toggle button incorrectly shows a moon icon (instead of a sun).
Describe the solution you'd like
The toggle button should visually represent the opposite of the current theme to indicate what the user will toggle to when clicked.
If the current theme is light, the toggle button should show a moon icon.
If the current theme is dark, the toggle button should show a sun icon.
Describe alternatives you've considered
I considered ignoring the visual inconsistency, but this may lead to user confusion and affect the overall user experience.
Approach to be followed (optional)
Check the logic for rendering the toggle button icon.
Ensure that the icon is dynamically updated based on the current theme state.
Test the functionality thoroughly to confirm alignment between the icon and theme.
The text was updated successfully, but these errors were encountered: