Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoherent Toggle button with light and dark mode #926

Closed
devagya-rattan opened this issue Jan 4, 2025 · 2 comments
Closed

Incoherent Toggle button with light and dark mode #926

devagya-rattan opened this issue Jan 4, 2025 · 2 comments

Comments

@devagya-rattan
Copy link

Is your feature request related to a problem? Please describe.
The toggle button on the website is not aligned with the theme it represents. For example:

When the default theme is light, the toggle button incorrectly shows a sun icon (instead of a moon).
When the theme is dark, the toggle button incorrectly shows a moon icon (instead of a sun).
Describe the solution you'd like
The toggle button should visually represent the opposite of the current theme to indicate what the user will toggle to when clicked.

If the current theme is light, the toggle button should show a moon icon.
If the current theme is dark, the toggle button should show a sun icon.
Describe alternatives you've considered
I considered ignoring the visual inconsistency, but this may lead to user confusion and affect the overall user experience.

Approach to be followed (optional)
Check the logic for rendering the toggle button icon.
Ensure that the icon is dynamically updated based on the current theme state.
Test the functionality thoroughly to confirm alignment between the icon and theme.
Screenshot (178)

Copy link

github-actions bot commented Jan 4, 2025

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@Cioppolo14
Copy link
Contributor

We are now focusing on three types of issues as priority areas:

  1. The improvement in the reliability of our code base. There are many issues created to test existing code. It is a good place to start if you want to understand the operation of various apps. When you submit PRs, we automatically check to see whether the code you submitted has been covered by testing and that each file meets the minimum standard level of the repository as a whole. You won’t be able to avoid understanding testing regimes to contribute to Talawa.
  2. The fixing of bugs and features that seriously hamper the user from using the application. The apps have various shortcomings. The most obvious ones are where the apps do not work as expected. For example buttons that don’t work, errors or messages that are not displayed to make the user understand what to do and many more. Think of any difficulty you have had in getting things working, there could be a bug there waiting for you.
  3. Coding of screens for issues created by our Contributor team based on our soon to be updated design guide. This may include updates to existing screens.
  4. The creation of additional or updated documentation that helps with improving both the experience of the end user and the various GitHub contributors who support the development of our software. This would include user guides.

We will only be accepting feature issues for deficiencies that are obviously lacking in the apps. These are things that make it very difficult to operate the apps. Even so, the PRs will still require you to understand testing as stated before.

Cosmetic changes that require only a few lines of code, or relate to screen sizes unlikely to be used are not acceptable under this policy.

Closing

@Cioppolo14 Cioppolo14 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants