Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Action Items corrections & Cleanup #2000

Closed
meetulr opened this issue Mar 13, 2024 · 1 comment
Closed

Fix: Action Items corrections & Cleanup #2000

meetulr opened this issue Mar 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@meetulr
Copy link
Contributor

meetulr commented Mar 13, 2024

Describe the bug

Some checks and cleanups are required in the code associated with action items and action item categories:

  1. In createActionItem mutation, a check should be added for disabled action item category, i.e. we should not be able to create an action item for a disabled action item category.
  2. In updateActionItemCategory mutation, an error message should be added for the cases we're updating its name to be one for which an action item category already exist.
  3. Remove unnecessary & unused queries that were made prematurely. actionItemCategory, actionItem.

Solution

  1. Add the required checks and error messages.
  2. Check for unused code and remove it.

Additional details

This is a cleanup issue, which is meant to take care of some bugs and oversights that I've noticed while working on the frontend for action items.

Action Items api-issue #1595
Action Items admin-issue PalisadoesFoundation/talawa-admin#1462

@meetulr meetulr added the bug Something isn't working label Mar 13, 2024
@meetulr
Copy link
Contributor Author

meetulr commented Mar 13, 2024

I would like to fix it.

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Mar 13, 2024
@palisadoes palisadoes removed the unapproved Unapproved for Pull Request label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants