Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated Documentation GitHub Action Fails #1487

Closed
palisadoes opened this issue Dec 11, 2023 · 9 comments
Closed

Automated Documentation GitHub Action Fails #1487

palisadoes opened this issue Dec 11, 2023 · 9 comments
Assignees
@hharshas
Labels
bug Something isn't working documentation Improvements or additions to documentation security Security fix

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 11, 2023 •
edited
Loading

Describe the bug

We recently updated the graphql-ws package as part of our weekly dependabot security update process. It passed our PR workflows.

This was quickly followed by these PRs

  1. chore(deps): bump @types/cors from 2.8.15 to 2.8.17 #1482
  2. chore(deps): bump i18n from 0.13.4 to 0.15.1 #1483
  3. chore(deps): bump ws from 8.14.2 to 8.15.0 #1485

Unfortunately the upgrade seems to have broken our documentation workflow

  1. https://github.com/PalisadoesFoundation/talawa-api/actions/runs/7169787735
  2. https://github.com/PalisadoesFoundation/talawa-api/actions/runs/7169800624
  3. https://github.com/PalisadoesFoundation/talawa-api/actions/runs/7169806847
  4. https://github.com/PalisadoesFoundation/talawa-api/actions/runs/7169811098

We need to fix the PR workflow.

To Reproduce

  1. Merge PR
  2. The documentation workflow fails

Expected behavior

  • The documentation push workflow passes

Actual behavior

  • See above

Screenshots

  • N/A

Additional details

  • NOTE: I will not be assigning people to issues, no exceptions. Please watch this video on how to proceed.

Click me to start video

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359
@palisadoes palisadoes added the bug Something isn't working label Dec 11, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation security Security fix unapproved Unapproved for Pull Request labels Dec 11, 2023
@ibishal
Copy link

ibishal commented Dec 11, 2023 •
edited
Loading

can i work on it? @noman2002

@RAGHAV-N5
Copy link

Please assign this issue to me.

@hharshas
Copy link

please assign me this issue

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Dec 12, 2023
@ibishal ibishal removed their assignment Dec 12, 2023
@RAGHAV-N5 RAGHAV-N5 removed their assignment Dec 17, 2023
@Veer0x1
Copy link
Contributor

Veer0x1 commented Dec 18, 2023

Can I take over this issue??

@palisadoes
Copy link
Contributor Author

We may have to close this.

Our GitHub member @anwersayeed has been working on this for some time. Anwer, should this be closed?

@anwersayeed
Copy link
Contributor

anwersayeed commented Dec 19, 2023 •
edited
Loading

@palisadoes I'm currently working on a similar but different issue. We can keep this issue open.

@github-actions GitHub Actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 30, 2023
@Veer0x1
Copy link
Contributor

Veer0x1 commented Dec 30, 2023

@anwersayeed can I work you along with this issue?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 31, 2023
@palisadoes
Copy link
Contributor Author

Closing. This is being handled by:

  1. Fix Documention Workflow - Talawa-Admin talawa-admin#1279
  2. Fix Documention Workflow - Talawa-API #1559

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hharshas hharshas

Labels
bug Something isn't working documentation Improvements or additions to documentation security Security fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@palisadoes @anwersayeed @Cioppolo14 @Veer0x1 @hharshas @RAGHAV-N5 @ibishal