-
-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LDAP authentication #1429
Comments
@aashimawadhwa Please assign me this issue. |
@aashimawadhwa I am getting error in pushing changes in talawa api from my local repository. And it is showing a lot of warning but there is no errors shown. Do I need to write test first to push the changes. |
@skbhagat0502 can you share a screenshot of it? |
@aashimawadhwa I am trying to commit since two days but I am not able to. It is showing that there is an errror. But I cannot see any. C:\Users\sande\OneDrive\Desktop\talawa-api\tests\helpers\membershipRequests.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\helpers\plugins.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\helpers\posts.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\helpers\tags.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\helpers\task.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\helpers\user.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\helpers\userAndOrg.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\ldapAuth\authController.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\libraries\errors\internalServerError.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\libraries\errors\unauthenticatedError.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\libraries\requestContext.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\libraries\requestTracing.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\middleware\isAuth.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\CheckIn\event.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\CheckIn\user.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Comment\creator.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\DirectChatMessage\directChatMessageBelongsTo.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\DirectChatMessage\receiver.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\DirectChatMessage\sender.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\DirectChat\creator.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\DirectChat\messages.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\DirectChat\organization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\DirectChat\users.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\EventProject\tasks.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Event\attendees.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Event\attendeesCheckInStatus.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Event\averageFeedbackScore.test.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Event\feedback.test.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Event\organization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Event\projects.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Feedback\event.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\GroupChatMessage\groupChatMessageBelongsTo.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\GroupChatMessage\sender.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\GroupChat\messages.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\GroupChat\users.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\MembershipRequest\organization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\MembershipRequest\user.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\acceptAdmin.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\acceptMembershipRequest.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\addEventAttendee.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\addFeedback.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\addLanguageTranslation.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\addOrganizationImage.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\addUserImage.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\addUserToGroupChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\adminRemoveEvent.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\adminRemoveGroup.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\assignUserTag.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\blockPluginCreationBySuperadmin.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\blockUser.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\cancelMembershipRequest.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\checkIn.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createAdmin.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createComment.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createDirectChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createEvent.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createEventProject.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createGroupChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createMember.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createMessageChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createOrganization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createPost.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createSampleOrganization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createTask.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\createUserTag.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\deleteAdvertisementById.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\deleteDonationById.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\forgotPassword.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\joinPublicOrganization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\leaveOrganization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\likeComment.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\likePost.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\login.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\otp.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\refreshToken.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\registerForEvent.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\rejectAdmin.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\rejectMembershipRequest.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeAdmin.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeAdvertisement.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeComment.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeDirectChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeEvent.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeEventAttendee.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeEventProject.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeGroupChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeMember.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeOrganization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeOrganizationImage.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removePost.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeSampleOrganization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeTask.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeUserFromGroupChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeUserImage.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\removeUserTag.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\sendMembershipRequest.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\sendMessageToDirectChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\sendMessageToGroupChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\setTaskVolunteers.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\signUp.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\togglePostPin.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\unassignUserTag.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\unblockUser.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\unlikeComment.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\unlikePost.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\unregisterForEventByUser.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\updateEvent.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\updateEventProject.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\updateOrganization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\updatePost.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\updateTask.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\updateUserPassword.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\updateUserProfile.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\updateUserRoleInOrganization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\updateUserTag.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Mutation\updateUserType.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Organization\creator.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Post\comments.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Post\creator.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\checkAuth.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\directChatsByUserID.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\directChatsMessagesByChatID.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\event.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\eventsByOrganizationConnection.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\getlanguage.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\hasSubmittedFeedback.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\me.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\myLanguage.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\organizationIsSample.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\organizations.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\organizationsConnection.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\organizationsMemberConnection.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\post.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\postsByOrganizationConnection.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\user.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\userLanguage.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\users.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Query\usersConnection.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Subscription\directMessageChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Subscription\messageSentToDirectChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Subscription\messageSentToGroupChat.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Task\creator.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Task\event.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\Task\volunteers.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\UserTag\childTags.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\UserTag\organization.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\UserTag\parentTag.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\UserTag\usersAssignedTo.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\User\assignedTasks.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\resolvers\middleware\currentUserExists.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\utilities\adminCheck.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\utilities\createSampleOrganizationUtil.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\utilities\deleteDuplicatedImage.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\utilities\deleteImage.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\utilities\encodedImageStorage\uploadEncodedImage.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\utilities\encodedVideoStorage\uploadEncodedVideo.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\utilities\imageAlreadyInDbCheck.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\utilities\mailer.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\utilities\reuploadDuplicateCheck.spec.ts C:\Users\sande\OneDrive\Desktop\talawa-api\tests\utilities\uploadImage.spec.ts ✖ 933 problems (2 errors, 931 warnings) husky - pre-commit hook exited with code 1 (error) |
@aashimawadhwa I manually commited the changes now. |
@skbhagat0502 The errors are probably due to work related to this PR. Merge your code with the latest |
@palisadoes my code is up to date with the latest develop/upstream, still facing the issue. |
@skbhagat0502 are you able to commit now? |
@tasneemkoushar I have already pushed the code manually. Do I need to do it again. |
@skbhagat0502 I spoke to one of the contributors and the concern I had about the user screens has already been solved. So you can go ahead with the issues in both repos as we discussed in slack |
Ok @palisadoes |
@tasneemkoushar I am not able to commit yet and getting the same error. I am commiting manually. |
@palisadoes I added the ldap login and register features. In the process of ldap registration the users email will be saved to the mongodb database also. This will ensure that the website do not break if authentication method is switched to ldap. Also I have ensured that superadmin will not be locked out and I have done this as we have disscussed in slack ie. with the help of LAST_RESORT_SUPERADMIN_EMAIL. |
@tasneemkoushar I got the issue which is causing this. This is because I have updated the vite.config.ts which is unauthorized. But it was important to do so. I have excluded some file like ldapConfig.ts and ldap.ts which was not important to cover with tests. All the configuration file were excluded for test so I too did this. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Closing due to inactivity and other priorities |
Is your feature request related to a problem? Please describe.
This issue is related to talawa admin issue number #1070
Describe the solution you'd like
Creating a ldap client for LDAP authentication in talawa api.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Approach to be followed (optional)
A clear and concise description of approach to be followed.
Additional context
Add any other context or screenshots about the feature request here.
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359
The text was updated successfully, but these errors were encountered: