From 6bf0d90217f68c137915e2568e636d9b1f730a42 Mon Sep 17 00:00:00 2001 From: dhirajudhani Date: Tue, 19 Nov 2024 22:31:34 +0530 Subject: [PATCH 1/3] Updated pr template with checklist --- .github/pull_request_template.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9e3081d0ee..35a507eeaa 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -23,6 +23,12 @@ Thanks for submitting a pull request! Please provide enough information so that Fixes # +**Code Quality Checklist:** + +- [ ] I have implemented all relevant CodeRabbit AI suggestions +- [ ] I have written tests for the changes made in this PR +- [ ] The test coverage meets or exceeds the current coverage threshold (~90-95%) + **Did you add tests for your changes?** @@ -50,4 +56,4 @@ Fixes # **Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa-admin/blob/master/CONTRIBUTING.md)?** - + \ No newline at end of file From ffe0c0d574f0d004678278c8dbe829e4f80d75cd Mon Sep 17 00:00:00 2001 From: dhirajudhani Date: Wed, 20 Nov 2024 07:30:26 +0530 Subject: [PATCH 2/3] Additional changes for the PR template --- .github/pull_request_template.md | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 35a507eeaa..9f95135796 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,6 +9,7 @@ We employ the following branching strategy to simplify the development process a NOTE!!! ONLY SUBMIT PRS AGAINST OUR `DEVELOP` BRANCH. THE DEFAULT IS `MAIN`, SO YOU WILL HAVE TO MODIFY THIS BEFORE SUBMITTING YOUR PR FOR REVIEW. PRS MADE AGAINST `MAIN` WILL BE CLOSED. + --> -**Code Quality Checklist:** - -- [ ] I have implemented all relevant CodeRabbit AI suggestions -- [ ] I have written tests for the changes made in this PR -- [ ] The test coverage meets or exceeds the current coverage threshold (~90-95%) - -**Did you add tests for your changes?** - - - **Snapshots/Videos:** @@ -50,10 +41,23 @@ Fixes # +## Checklist + +### CodeRabbit AI Review +- [ ] I have reviewed and addressed all critical issues flagged by CodeRabbit AI +- [ ] I have implemented or provided justification for each non-critical suggestion +- [ ] I have documented my reasoning in the PR comments where CodeRabbit AI suggestions were not implemented + +### Test Coverage +- [ ] I have written tests for all new changes/features +- [ ] I have verified that test coverage meets or exceeds 95% +- [ ] I have run the test suite locally and all tests pass + + **Other information** -**Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa-admin/blob/master/CONTRIBUTING.md)?** +**Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa-api/blob/master/CONTRIBUTING.md)?** \ No newline at end of file From b9a1e2c8de30190a68c558124c07636dc97881ed Mon Sep 17 00:00:00 2001 From: dhirajudhani Date: Wed, 20 Nov 2024 07:42:21 +0530 Subject: [PATCH 3/3] Changed the url for the PR template --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9f95135796..a1e203bfdf 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -58,6 +58,6 @@ Fixes # -**Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa-api/blob/master/CONTRIBUTING.md)?** +**Have you read the [contributing guide](https://github.com/PalisadoesFoundation/talawa-admin/blob/master/CONTRIBUTING.md)?** \ No newline at end of file