Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS in src/components/CheckIn/tagTemplate.ts #2906

Open
palisadoes opened this issue Dec 26, 2024 · 5 comments
Open

Refactor CSS in src/components/CheckIn/tagTemplate.ts #2906

palisadoes opened this issue Dec 26, 2024 · 5 comments
Assignees
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

Refactor CSS in this file

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

This file contains embedded CSS references that should be completely moved to:

  • src/style/app.module.css

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is for this file to use this new design pattern. This means that:

  1. All embedded CSS in this file must be merged into the global CSS file using pre-existing CSS.
  2. All embedded CSS in this file must be removed
@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Dec 26, 2024
@palisadoes palisadoes changed the title Refactor CSS in /src/components/CheckIn/tagTemplate.ts Refactor CSS in src/components/CheckIn/tagTemplate.ts Dec 26, 2024
@IITI-tushar
Copy link
Contributor

@palisadoes, please assign.. I will submit a PR soon...

@abhassen44
Copy link

@palisadoes,you mean all .modules.css + tailwind + inline css we have to combine and place them in app.module.css
or only tailwind + inline css we have place them in app.module.css

@palisadoes
Copy link
Contributor Author

  1. Please move all the inline CSS to app.module.css
  2. We will need to do this so that we can easily implement
    1. light/dark mode
    2. custom css for the end user

@IITI-tushar
Copy link
Contributor

@abhassen44 This issue is assigned to me. If you want to work on an issue please try to find another and get assigned to it...

@abhassen44
Copy link

@IITI-tushar ,i am just asking to understand the requirement and to understand the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

3 participants