Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CSS in src/screens/UserPortal/Events/Events.tsx #2892

Closed
palisadoes opened this issue Dec 26, 2024 · 2 comments
Closed

Refactor CSS in src/screens/UserPortal/Events/Events.tsx #2892

palisadoes opened this issue Dec 26, 2024 · 2 comments
Assignees
@hustlernik
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

Refactor CSS in this file

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

This file contains embedded CSS references that should be completely moved to:

  • src/style/app.module.css

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is for this file to use this new design pattern. This means that:

  1. All embedded CSS in this file must be merged into the global CSS file using pre-existing CSS.
  2. All embedded CSS in this file must be removed
@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Dec 26, 2024
@palisadoes palisadoes changed the title Refactor CSS in /screens/UserPortal/Events/Events.spec.tsx Refactor CSS in src/screens/UserPortal/Events/Events.spec.tsx Dec 26, 2024
@hustlernik
Copy link
Contributor

@palisadoes src/screens/UserPortal/Events/Events.spec.tsx are you sure, you need this file to be refactored?

@hustlernik
Copy link
Contributor

@palisadoes May I take this up if it is src/screens/UserPortal/Events/Events.tsx?

@palisadoes palisadoes changed the title Refactor CSS in src/screens/UserPortal/Events/Events.spec.tsx Refactor CSS in src/screens/UserPortal/Events/Events.tsx Dec 26, 2024
@hustlernik hustlernik mentioned this issue Dec 28, 2024
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa Admin - Refactoring Dec 28, 2024
@coderabbitai coderabbitai bot mentioned this issue Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hustlernik hustlernik

Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
2024 New Talawa Admin Screens
Archived in project
Talawa Admin - Refactoring
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@palisadoes @hustlernik