Bug : Simplify error messages for user at Talawa User Portal

[bandhan-majumder]

Describe the bug
In Talawa User portal when the user tries to update information with empty or invalid data, error in not user friendly way appears. Makes it hard to understand the user what required fields they are missing or giving an invalid data into.

To Reproduce
Steps to reproduce the behavior:

1. Go to Talawa User Portal
2. Go to settings
3. Submit data in invalid or empty format
4. Click on save changes

Expected behavior
Error should come one by one in a user friendly format.

Actual behavior

Variable "$phoneNumber" got invalid value ""; Value is not a valid phone number of the form +17895551234 (7-15 digits): Variable "$grade" got invalid value ""; Value "" does not exist in "EducationGrade" enum. Variable "$empStatus" got invalid value ""; Value "" does not exist in "EmploymentStatus" enum. Variable "$maritalStatus" got invalid value ""; Value "" does not exist in "MaritalStatus" enum.

Screenshots

Additional details
Add any other context or screenshots about the feature request here.

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

• Student Internship Programs talawa#359

[github-actions]

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

[bandhan-majumder]

I would like to work on this issue. And please clarify my doubt that my changes should be pushed against develop or develop-postgres branch cause talawa-api's develop-postgres branch is not ready yet.

[palisadoes]

1. Will your solution work in all cases in the app, or just this particular one?
2. Will you have translations for your error(s)?

[bandhan-majumder]

1. As the submit handler of this is different, it will work for this section only. But if we need, we can easily make it work for other handlers as well.
2. Yes

[palisadoes]

Is a universal handler feasible?

[bandhan-majumder]

Wherever the error occurs, if we do tErrors('specificErrorName') it will show the user friendly version of the specific error message. Here is an example of how existing talawaApiUnavailable error message is present in different places but maps to the same error message.

presents in places:

maps to the same:

[palisadoes]

Will you be able to do the code updates for all the cases with tests to resolve this issue?

[bandhan-majumder]

I have solved this particular issue locally. Should I raise a PR and then you can suggest changes/modifications it needs!!

[gurramkarthiknetha]

i fixed this issue can i raise a PR

[gurramkarthiknetha]

i sloved this issue

[gurramkarthiknetha]

could you please assign this issue to me i will raise a pr

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[bandhan-majumder]

I am unassigning myself from this as nobody is responding. There is a PR open at #2500 . I am unable to get new issues. Happy to look at it if anything needs change.

[varshith257]

Fixed by #2500