-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Image Load issue in Avatar across Admin/User Portal #2415
Comments
please assign me this issue |
Hi @palisadoes , could you assign this issue to me? Here's how I’d approach it: I’ll start by updating instances of .toDataUriSync to .toDataUri wherever needed. Since .toDataUri now returns a promise, I’ll make sure each instance is properly awaited to handle the async response. Next, I’ll adjust any functions that depend on .toDataUri by adding async where necessary, or restructuring the function flow to support async calls. After making these changes, I’ll thoroughly test the Admin Portal to ensure the organization avatars load as expected. If there aren’t already unit tests for avatar generation, I’ll add some to help catch similar issues if there are future updates. |
@GlenDsza Would you like to work on this? |
Yes I would work on it |
During the week of November 11, 2024 we will start a code freeze on the We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology. Starting November 12, California time no new PRs will be accepted against the There are some GSoC project features that will need to be merged into develop. These will be the only exceptions. This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post. |
Hello @palisadoes, could you please guide me on how to contribute to backend development and suggest where I should focus my contributions? |
Here is Our Getting Started - Developers YouTube playlist, it has all you need to know to get started. Please listen to all of them as they will help to set your expectations. |
This issue is already assigned. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
Can you assign this issue to me !! |
Closing, the issue seems to have been fixed |
Describe the bug
A recent PR to bump dicebear library cause issue due to changing .
toDataUriSync
method to .toDataUri
and not awaiting for promise.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Organizations avatars should be visible
Actual behavior
Organizations avatars are not loaded
Screenshots
The text was updated successfully, but these errors were encountered: