Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: Create PR GitHub Actions logic for the ignore-protected-files-pr label #2383

Closed
varshith257 opened this issue Oct 29, 2024 · 4 comments · Fixed by #2391
Closed

Admin: Create PR GitHub Actions logic for the ignore-protected-files-pr label #2383

varshith257 opened this issue Oct 29, 2024 · 4 comments · Fixed by #2391
Assignees
Labels
feature request no-issue-activity No issue activity test Testing application

Comments

@varshith257
Copy link
Member

Is your feature request related to a problem? Please describe.

  1. The pull-request.yml workflow file has a section called Check-Sensitive-Files
  2. This GitHub action:
    1. was created to flag PRs that edited sensitive files that we want to protect from unauthorized changes
    2. is run on all PRs except those submitted by dependabot
  3. There are cases where community members need to edit sensitive files. When this is done, the Check-Sensitive-Files test fails. Our formal GitHub contributors can only merge PRs where all tests pass. This means the Repository owners have to merge the PRs. This creates a bottleneck in PR reviews

Describe the solution you'd like

  1. There is a ignore-sensitive-files-pr label in this repository
  2. We want only the Check-Sensitive-Files GitHub action to be ignored if this label is applied to the PR by any of our GitHub contributors
  3. No other functionality must be altered, especially the logic where the Check-Sensitive-Files GitHub action is also not run when the PR author is the dependabot user.

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context

  • N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files test Testing application unapproved labels Oct 29, 2024
@varshith257
Copy link
Member Author

@varshith257 varshith257 removed unapproved ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files labels Oct 29, 2024
@varshith257
Copy link
Member Author

@govindsingh3477 Ask to get it assigned, if you are available

@govindsingh3477
Copy link
Contributor

Please assign.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 10, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa-Admin (Tests) Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request no-issue-activity No issue activity test Testing application
Projects
Archived in project
3 participants