Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Unittests for src/screens/OrganizationPeople/AddMember.tsx #2375

Open
palisadoes opened this issue Oct 27, 2024 · 9 comments
Open

Write Unittests for src/screens/OrganizationPeople/AddMember.tsx #2375

palisadoes opened this issue Oct 27, 2024 · 9 comments
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

We will need unittests done for all methods, classes and functions found in this file.

PR Acceptance Criteria

  1. When complete this file must show 100% coverage when merged into the code base.
  2. The current code coverage for the file can be found here
  3. CodeRabbit must approve all your changes to the test file(s) and the file(s) under test
  4. The PR will show a report for the code coverage for the file you have added. You can use that as a guide
  5. No functionality must be removed to achieve this goal
  6. All tests must be valid and truly test the code base

Other Criteria

  1. If this file isn't referenced in the code base then remove it. We don't want tests run on unused code

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@sethdivyansh
Copy link

please assign me.

@sethdivyansh sethdivyansh removed their assignment Nov 5, 2024
@ARYANSHAH1567
Copy link

Can you please assign it to me?

@Kunalpal216
Copy link

If there are no updates by @ARYANSHAH1567 , Can this issue be assigned to me ?

@ARYANSHAH1567
Copy link

I am working on it

@palisadoes
Copy link
Contributor Author

During the week of November 11, 2024 we will start a code freeze on the develop branches in Talawa, Talawa Admin and Talawa-API.

We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the develop branches to a new develop-postrgres branch in each repository.

Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology.

Starting November 12, California time no new PRs will be accepted against the develop branch. They must be applied to the develop-postrgres branch.

There are some GSoC project features that will need to be merged into develop. These will be the only exceptions.

This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 21, 2024
@Cioppolo14
Copy link

@ARYANSHAH1567 Are you working on this?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Nov 22, 2024
@ARYANSHAH1567
Copy link

@ARYANSHAH1567 Are you working on this?

No, Actually i am a little busy and i think it would take quite a bit time because there are some tests that are always true and not checking anything. So for now i would like to unassign this

@ARYANSHAH1567 ARYANSHAH1567 removed their assignment Nov 22, 2024
@PAVAN507-STAR
Copy link

@palisadoes Can i work on this issue?

@palisadoes palisadoes moved this from Backlog to In progress in Talawa-Admin (Tests) Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
Status: In progress
Development

No branches or pull requests

7 participants