Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations Are Not Correctly Tested in Our PR Workflow #2260

Closed
palisadoes opened this issue Sep 10, 2024 · 1 comment · Fixed by #2263
Closed

Translations Are Not Correctly Tested in Our PR Workflow #2260

palisadoes opened this issue Sep 10, 2024 · 1 comment · Fixed by #2263
Assignees
Labels
bug Something isn't working good first issue Good for newcomers test Testing application ui/ux issue related and being worked with the figma file of the Admin UI unapproved

Comments

@palisadoes
Copy link
Contributor

Describe the bug

  1. Multilingual support is an important feature of our application.
  2. We need to ensure that we have translations created for every language entry
  3. We created a script to test for this in Talawa mobile to test for this. It was added to this repo, but doesn't appear to work.
    1. Script Update: Detailed Error Output for Translation Mismatches talawa#2284
  4. We need to apply the script to this repository and make adjustments where necessary. Ideally the script in both repos must be identical and apply the logic to different directory trees. Make updates accordingly.
  5. Without correct translations, the end user UI/UX is unacceptable.

To Reproduce

  • See the Actual behavior section below

Expected behavior

  1. We need to create a GitHub action that during the PR process checks all the translation files to make sure that there are translations in all the non-default languages for each English default language entry.
  2. As part of the PR for this issue, all the translations must be correctly present

Actual behavior

  1. This PR failed to notice the incomplete translations
    1. Fixes multiple add members screen layout issues #2232 #2254
  2. Only one translation file was edited
    image
  3. There are no errors in the PR workflow
    image
    image

Screenshots

  • See above

Additional details

  • N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added bug Something isn't working good first issue Good for newcomers ui/ux issue related and being worked with the figma file of the Admin UI labels Sep 10, 2024
@github-actions github-actions bot added test Testing application unapproved labels Sep 10, 2024
@Nandika-A
Copy link
Contributor

Hi @palisadoes ! Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers test Testing application ui/ux issue related and being worked with the figma file of the Admin UI unapproved
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants