Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left drawer doesn't change when a new organization language is selected #1925

Closed
palisadoes opened this issue Apr 23, 2024 · 12 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Apr 23, 2024

Describe the bug

The left drawer doesn't change when a new organization language is selected

To Reproduce

Steps to reproduce the behavior:

  1. Select a new language for the organization
  2. The left drawer doesn't update

Expected behavior

  1. Select a new language for the organization
  2. The left drawer updates
  3. All tests must be valid and pass. They must test the fixing of this bug

Actual behavior

  • See above

Screenshots

  1. Select a new language for the organization

    image

  2. The left drawer doesn't update

    image

Additional details

  • See above

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Apr 23, 2024
@github-actions github-actions bot added test Testing application unapproved labels Apr 23, 2024
@palisadoes palisadoes changed the title Bug Report Left drawer doesn't change when a new organization language is selected Apr 23, 2024
@palisadoes palisadoes removed the test Testing application label Apr 23, 2024
@pranshugupta54
Copy link
Member

Please assign this, I'm working on a related issue - #1579

@Cioppolo14
Copy link
Contributor

I have assigned since the two issues are related.

Copy link

github-actions bot commented May 4, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label May 4, 2024
@dhanagopu
Copy link

@pranshugupta54 Are you still working on this?

@pranshugupta54
Copy link
Member

This is linked to another issue and we were planning to implement a full new better way.

@Cioppolo14
Copy link
Contributor

@pranshugupta54 Just to clarify, is this issue on hold or is there a new issue with the better method we should keep open and close this?

@pranshugupta54
Copy link
Member

pranshugupta54 commented May 4, 2024

@Cioppolo14, we're keeping this on hold for now. I was having conversation with Peter (today itself) and we were kinda deciding about fixing translations completely. (Which will require huge changes)

@github-actions github-actions bot removed the no-issue-activity No issue activity label May 5, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label May 16, 2024
@pranshugupta54
Copy link
Member

We've kinda planned the timeline for this, I'll be making a PR soon for translations (this issue will be a part of it)

@github-actions github-actions bot removed the no-issue-activity No issue activity label May 17, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label May 27, 2024
@pranshugupta54
Copy link
Member

Working on this now, after #2002

@palisadoes
Copy link
Contributor Author

@pranshugupta54

We need to reconsider how we handle languages.

We have an organization level language setting, however this is insufficient if the end user wants to use a different language. We need to think of a way to handle per user language preferences. This will need to be implemented for both Admin and Mobile. Please create issues for this so we can track. We'll probably need ones for all three code repos to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants