Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect Usage of Removed Mutation updateUserType in Organization People Screen #1907

Closed
akhilender-bongirwar opened this issue Apr 16, 2024 · 5 comments
Labels
bug Something isn't working unapproved

Comments

@akhilender-bongirwar
Copy link
Contributor

Describe the bug

Despite the recent update in the userType feature, where the updateUserType mutation was removed, it is still being used in the Organization People screen within the orgAdminListCard.tsx file for removing admins.

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to Organization People screen
  2. Attempt to remove any admin present in the organization.
  3. You will be encountering an error message with status 400.

Expected behavior
The updateUserType mutation should be modified according to the new userType fix.

Actual behavior
The updateUserType mutation persists in the codebase and is being utilized in the Organization People screen, despite its removal from the API.

Screenshots
image
image

Additional details
The API PR - Link which removed the mutation.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@akhilender-bongirwar akhilender-bongirwar added the bug Something isn't working label Apr 16, 2024
@akhilender-bongirwar
Copy link
Contributor Author

@kanhaiya04, this issue is also related to the Organization People screen. Can you work on this as it is an extension for issue #1905

@kanhaiya04
Copy link
Contributor

@akhilender-bongirwar, I have already considered and fixed this issue in PR #1902.

@kanhaiya04
Copy link
Contributor

@palisadoes, You can close this issue.

@akhilender-bongirwar
Copy link
Contributor Author

Thanks for informing @kanhaiya04 👍

@akhilender-bongirwar akhilender-bongirwar closed this as not planned Won't fix, can't repro, duplicate, stale Apr 16, 2024
@akhilender-bongirwar
Copy link
Contributor Author

@kanhaiya04, I guess you can fix the issue #1905 in the same PR #1902 since it is related to Organization People screen itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unapproved
Projects
None yet
Development

No branches or pull requests

2 participants