Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating from CRA to Vite #1848

Closed
lakshz opened this issue Mar 30, 2024 Discussed in #1838 · 2 comments
Closed

Migrating from CRA to Vite #1848

lakshz opened this issue Mar 30, 2024 Discussed in #1838 · 2 comments
Labels
dependencies Pull requests that update a dependency file unapproved

Comments

@lakshz
Copy link
Contributor

lakshz commented Mar 30, 2024 •
edited
Loading

Discussed in #1838

Originally posted by lakshz March 28, 2024
We should consider migrating from CRA to Vite for the following reasons:

  1. Faster build time. Hence, a better development experience
  2. Optimized production builds
  3. More compliant with modern/best practices

The only hurdle can be compatibility. We'll have to make sure all the existing dependencies work well with Vite.
@github-actions github-actions bot added dependencies Pull requests that update a dependency file unapproved labels Mar 30, 2024
@lakshz
Copy link
Contributor Author

lakshz commented Mar 30, 2024

I would like to work on it, if this sounds good.

@Cioppolo14
Copy link
Contributor

@lakshz Please get more feedback in the slack discussion before opening an issue. We need a consensus.

@Cioppolo14 Cioppolo14 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file unapproved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cioppolo14 @lakshz