Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[userTypeFix]: Organizations not Visible Error #1768

Closed
varshith257 opened this issue Mar 23, 2024 · 7 comments
Closed

[userTypeFix]: Organizations not Visible Error #1768

varshith257 opened this issue Mar 23, 2024 · 7 comments
Assignees
Labels
bug Something isn't working feature request good first issue Good for newcomers GSoC Priority

Comments

@varshith257
Copy link
Member

varshith257 commented Mar 23, 2024

Describe the bug

  1. After login as Admin/SuperAdmin, the organizations aren't rendered/loaded correctly
  2. They flash on briefly, then the not found error appears

NOTE

  1. It appears to work OK for the test users here
    1. https://github.com/PalisadoesFoundation/talawa-api/blob/develop/INSTALLATION.md#user-accounts-and-organizations
  2. It does not work for a newly registered LAST_RESORT_SUPERADMIN_EMAIL
    1. https://github.com/PalisadoesFoundation/talawa-api/blob/develop/INSTALLATION.md#setting-up-env-last_resort_superadmin_email-parameter-in-the-env-file

To Reproduce

Steps to reproduce the behavior:

  1. Login as Admin/SuperAdmin
  2. Look at My Organizations Screen

Organizations Screen show Organization not found error

Expected behavior

Organizations have to be loaded correctly without any issues

Screenshots

Kazam_screencast_00030.mp4

Additional details
Add any other context or screenshots about the feature request here.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@varshith257 varshith257 added the bug Something isn't working label Mar 23, 2024
@palisadoes palisadoes changed the title [userTypeFix]: Organizations not Found Error [userTypeFix]: Organizations not Visible Error Mar 23, 2024
@Doraemon012
Copy link
Member

@palisadoes I would like to work on this issue, please assign it to me.

@palisadoes
Copy link
Contributor

@palisadoes
Copy link
Contributor

@Doraemon012 Please write a test to make sure the superadmin of last resort doesn't have this issue again.

@AVtheking
Copy link
Contributor

@Doraemon012 the issue is in this line
image
add check for superAdmin also so that it shows organization for super admin even if admin For field is empty

@palisadoes
Copy link
Contributor

We are tracking this issue with one of our projects, and we'd like to track its progress especially as the GSoC announcement dates draw near.

  1. When you create your PR, please link it back to this project:
    1. https://github.com/orgs/PalisadoesFoundation/projects/24/views/1
  2. The process is simple. It can be found here:
    1. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#manually-linking-a-pull-request-to-an-issue-using-the-pull-request-sidebar

@palisadoes
Copy link
Contributor

@Doraemon012

This is a really glaring flaw in our app logic. How is your progress on resolving this?

@Doraemon012
Copy link
Member

@palisadoes I have raised a PR for this. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request good first issue Good for newcomers GSoC Priority
Projects
Archived in project
Development

No branches or pull requests

4 participants