Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update member information on Organization Card #1538

Closed
palisadoes opened this issue Feb 3, 2024 · 11 comments
Closed

Update member information on Organization Card #1538

palisadoes opened this issue Feb 3, 2024 · 11 comments
Assignees
Labels
feature request ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Feb 3, 2024

Is your feature request related to a problem? Please describe.

  1. The Organization cards on the /orglist URI page have insufficient data
  2. If the names are all the same, then you have to use the city location, the number of users and admins as a guide.
    1. If you have more than one organization with the same name in the same city, then it'll be hard to differentiate

Describe the solution you'd like

  1. Add a single line description below the Organization name
  2. Improve the current aesthetic of the page.
    1. We recently added the city, country and postal code information which has made the cards cluttered. This information must be maintained.
    2. The member and admin information must be maintained but can be on the same line
    3. Remove the location icons
  3. Use our Design System Figma files as a guide
    1. https://docs.talawa.io/docs/design/ux/ux-design-system/

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  1. Create a Figma example before starting
  2. Ask @aashimawadhwa @rishav-jha-mech for design approvals before making a PR

Additional context

Additional context
image

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@github-actions github-actions bot added ui/ux issue related and being worked with the figma file of the Admin UI unapproved labels Feb 3, 2024
@1010varun
Copy link
Contributor

@palisadoes assign this to me

@1010varun
Copy link
Contributor

Hey @palisadoes,
I have recreated the card according to the requirements.
Features Implemented:

  1. Added a single line of description about the org, also added a validation that will validate the length, and if it exceeds the length, then it will be broken and truncated by three dots(...). Upon hovering, the user can see the full description shown in the image.

  2. Removed location icons.

  3. Made Admins and Members info. on the same line.

Kindly review all these changes and suggest if any changes are needed.

Before:
image

After:
image

@palisadoes
Copy link
Contributor Author

  1. The words City, Country are not required.
  2. There is no need for brackets around the postal codes.
  3. If there is no postal code and/or state there must not commas with not text following

Submit a PR when ready

@1010varun
Copy link
Contributor

Okay will make all these changes and raise a PR soon.

@palisadoes
Copy link
Contributor Author

We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:

  1. We start looking for people to review PRs when you submit them.
  2. We often contact them and link to the PR. If the PR is closed the whole effort is wasted.
  3. The historical thread of reviewer comments is broken when the work is spread across multiple PRs. The quality of our code is affected negatively.

Please be considerate of our volunteers' limited time and our desire to improve our code base.

This policy is stated as a pinned post in all our Talawa repositories. Our YouTube videos explain why this practice is not acceptable to our Community.

@palisadoes
Copy link
Contributor Author

This is available for reassignment

@1010varun
Copy link
Contributor

Sir please reassign this to me I have raised a PR for the same

@palisadoes
Copy link
Contributor Author

You have done so 4 times before and closed them. It's time for someone else to get a chance.

@AmitSharma512
Copy link
Contributor

@palisadoes can i work on this :))

@AmitSharma512
Copy link
Contributor

@palisadoes I am working on this issue, but due to some unavoidable circumstances, the PR submission is getting delayed, but I will definitely make the PR by this Sunday, so I am requesting you grant me some time.

Copy link

github-actions bot commented Mar 1, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added no-issue-activity No issue activity and removed no-issue-activity No issue activity labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ui/ux issue related and being worked with the figma file of the Admin UI
Projects
None yet
Development

No branches or pull requests

3 participants