Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: GitHub Action - Failure when PRs made against the main branch #1435

Closed
palisadoes opened this issue Jan 15, 2024 · 2 comments
Closed
Assignees

Comments

@palisadoes
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We are having an increasing number of PRs made against the main branch when they should be made against the develop branch.

Describe the solution you'd like

  1. We need a separate job added to the end of this GitHub action file that has no needs: statement that tests to make sure that the target branch of the PR is develop. It must fail without affecting any of the other jobs in the file. The aim of this is to alert contributors of their likely mistake as in most cases we will be merging against develop
  2. There must be messaging that explains that the job is testing whether the develop branch is being used.

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context

Sample PR made against main

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@akhilender-bongirwar
Copy link
Contributor

I would like to work on this issue. Please assign me.

@Veer0x1
Copy link
Contributor

Veer0x1 commented Jan 15, 2024

I would like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants