Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Registrations with a User Type - Admin #1273

Closed
palisadoes opened this issue Dec 24, 2023 · 11 comments
Closed

Update Registrations with a User Type - Admin #1273

palisadoes opened this issue Dec 24, 2023 · 11 comments
Assignees

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 24, 2023

Is your feature request related to a problem? Please describe.

Currently our application assumes that all persons tracked in the database are Talawa users. This may not be the case in practice. Administrators will require the ability to manage people who either cannot access our apps or don't want to.

Describe the solution you'd like

There are requirements dependent upon the repository

API

  1. We need to update the User collection to have a User Type field that could have at a minimum these possible values
    1. App User
    2. Non App User
  2. This will need to be a mandatory field
  3. Mutations for this field will need to be created for the User and related collections

The aim is that this field will be automatically populated during the registration process. Here are some examples:

  1. Registrations through the mobile app would automatically be by an App User
  2. Registrations through the Admin Portal and User Portal features of the Talawa Admin web app would automatically be by an App User
  3. Admins may want to manually add Users who may be an App User or a Non App User
  4. Persons attending events may need to be checked in. If they are new to the organization, then the event organizer may want to add them as a Non App User

Admin

We require this from you:

  1. Registrations through the Admin Portal and User Portal features of the Talawa Admin web app would automatically be by an App User and the DB must be updated accordingly

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

  • See above

Additional context
Related issues include:

  1. Create an User Type Flag Field talawa-api#1552 (Prerequisite)
  2. Update Registrations with a User Type - Mobile talawa#2269
  3. Update Registrations with a User Type - Admin #1273

Other

  • Valid tests for this must be created as part of the resolution of this issue

Potential internship candidates

@adi790uu
Copy link
Contributor

hey i would like to work on this!

@gauravsingh94
Copy link
Contributor

Please assign this one to me.

Copy link

github-actions bot commented Jan 5, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 5, 2024
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity

@Shubh152
Copy link
Contributor

Shubh152 commented Jan 5, 2024

Please assign this issue to me @Cioppolo14

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 6, 2024
@Shubh152
Copy link
Contributor

Shubh152 commented Jan 7, 2024

Unassigning as prerequisite not yet satisfied

@Shubh152 Shubh152 removed their assignment Jan 7, 2024
@1010varun
Copy link
Contributor

hey @Shubh152 can you please tell me what the prerequisites are?
@Cioppolo14 assign this issue to me

@Cioppolo14
Copy link
Contributor

@1010varun I think #1552 in Talawa-API is the prereq, see above. Do you still want this issue?

@adi790uu
Copy link
Contributor

adi790uu commented Jan 9, 2024

Hey @Cioppolo14 would like to take this up again!

@adi790uu
Copy link
Contributor

adi790uu commented Jan 12, 2024

Hey @palisadoes is this issue still valid as we have changed the whole approach by adding the NON_USER field in the enum and a new user is give the role of USER automatically.

@Cioppolo14
Copy link
Contributor

@adi790uu Thank you. You are correct we don't need this issue. I am going to close this now.

@Cioppolo14 Cioppolo14 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants