-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Talawa-Admin Docker Support Issue #1075
Comments
Hey @palisadoes please assign me this issue. |
@duplixx Do we even need docker on the admin? If yes, please explain why we need it. |
Hey @noman2002 , I strongly believe that integrating Docker into Talawa-Admin is essential. It effectively addresses significant challenges faced by developers and contributors.
In summary, leveraging Docker in Talawa-Admin significantly improves collaboration, consistency, and reduces common challenges associated with environment setups. |
@kb-0311 @beingnoble03 @DMills27 @EshaanAgg would like to hear your thoughts on this. |
Docker is essentially being used as a stop gap, at the moment, until we can put in place a more sustainable means to achieve reproducibility. I propose we have a single Docker image that generates the API, Admin and Talawa Mobile Frontend. My reasoning is that it would incur additional complexity to create separate Docker images for these and then connect them; it is also inefficient in terms of computational resources that would be used. |
|
I could make a dockerfile for Talawa-Admin. I there is a need, Please assign this issue to me. |
In my view we should follow this approach 1. Dockerfile for Each Component
2. Docker Compose for Multi-Container Setup
3. Service Orchestration
|
@DMills27 @palisadoes Is this issue required or should we close this for now ?? |
It would only make sense for this issue if we publish the |
Thanks @EshaanAgg . |
@EshaanAgg As you spoke about publishing Talawa* on Docker Hub, should we reopen this issue? |
We are yet to make a docker image for Talawa APi. It would be apt to reopen the same after it. |
The API got its docker instance created about 2 weeks ago. So we should reopen this issue. |
can i get assigned? |
@EshaanAgg @noman2002 is the talawa image is published on dockerhub i cant see it? |
@palisadoes please assign this issue to me, would love to work |
@palisadoes can i work on this issue! |
Hey @aashimawadhwa and @palisadoes I'm currently working on dockerizing Talawa Admin. To set up the Docker Compose file, I need the Docker image for Talawa API, but I couldn't find it anywhere. Could you please guide me in the right direction or provide information about where I can obtain the Talawa API Docker image? Thanks! |
|
Okay, thanks! |
@vasujain275 Sorry for the delay, I am back on it. I will follow up soon. Feel free to find me on slack too. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
I am working on the review. Starting with API and working my way through. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
@palisadoes I understand that the primary goal of the PR is to ensure the correct startup of Talawa-Admin within a Docker container, which is a valuable addition to the workflow. However, I believe that creating a Dockerfile for Talawa-Admin would significantly enhance its deployment and scalability. This would allow for a more self-contained and easily deployable application |
@palisadoes @DMills27 @noman2002 @varshith257 I'm open to collaborating with you and other contributors to implement Docker support for Talawa-Admin. We can discuss specific strategies and potential challenges. Please let me know if you have any questions or require further assistance. |
@VanshikaSabharwal You can refer the previous attempt made which is close to what we need |
Okay i get it |
If the problem is fixed, please open the PR |
During the week of November 11, 2024 we will start a code freeze on the We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology. Starting November 12, California time no new PRs will be accepted against the There are some GSoC project features that will need to be merged into develop. These will be the only exceptions. This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post. |
Yes, This PR solves the issue. #2414 |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
This issue was solved as a part of #2414 |
@palisadoes You can close this issue as completed |
Talawa-Admin Docker Support Issue:
Title:
Adding Docker Support to Talawa-Admin
Description:
Problem:
Talawa-Admin currently lacks Docker support, hindering its ease of deployment and scalability. Adding Docker support is essential to streamline the deployment process and make it more accessible to a broader audience.
Solution:
Implementing Docker support for Talawa-Admin would involve creating a Dockerfile and configuration to package the application into a Docker container. This containerization would simplify deployment, improve consistency across environments, and enhance scalability.
Approach:
To achieve Docker support for Talawa-Admin, we can follow these steps:
Additional Context:
Adding Docker support aligns with modern development practices, making it easier for developers to set up and run Talawa-Admin in various environments. Docker containers provide isolation, portability, and reproducibility, contributing to a more robust and user-friendly development and deployment experience.
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359
The text was updated successfully, but these errors were encountered: