Code Coverage: Create tests for src/components/UserPortal/Login/Login.tsx

[palisadoes]

We will need unittests done for all methods, classes and functions found in this file.

Any widgets, components, modals referenced in this file must also have unittests done

PR Acceptance Criteria

• When complete this file must show at least 100% coverage when merged into the code base.
• The current code coverage for the file can be found here
• The PR will show a report for the code coverage for the file you have added. You can use that as a guide
• Please coordinate issue assignment and PR reviews with the contributors listed in this issue Student Internship Programs talawa#359

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[MahendraDani]

I read the current tests in Login.test.tsx and observed the current code coverage.
We can observe that codecov says only lines 54 and 55 are not covered in the tests :

talawa-admin/src/components/UserPortal/Login/Login.tsx

Lines 54 to 55 in d8e6a7d

	} else {
	toast.warn(t('notAuthorised'));

After trying all the possible case locally I found out that the control does not reach on the above lines in any cases. In other words when handleLogin function is triggered with non-empty email and password fields the data will always be returned and hence the else condition (when data is empty as returned by login mutation) never occurs.

Thus to get the test coverage of this component to 100% is to simply remove the else condition i.e

talawa-admin/src/components/UserPortal/Login/Login.tsx

Lines 54 to 55 in d8e6a7d

	} else {
	toast.warn(t('notAuthorised'));

It does not break the functioning of user portal and the test coverage also reaches to 100%.
Please let me know if this approach is correct or there is something else need to be done?
I would like to work on this issue

cc : @noman2002

[noman2002]

Try to mock the situation in which it goes to the else condition. And write the test for the same. Removing the else condition will not be a good approach.

[MahendraDani]

Try to mock the situation in which it goes to the else condition. And write the test for the same. Removing the else condition will not be a good approach.

I will try

[MahendraDani]

@noman2002
Are admins and superadmin allowed to login into user portal?
Because when I was trying to mock all possible situations I found that we can login into user portal using admin or superadmin credentails.

Steps to reproduce

1. Go to user portal - localhost:3000/user
2. Enter credentials of admins or superadmins
3. Click on Login button.
4. You will be logged into user portal as admin or superadmin

[noman2002]

Yes admin can login to user portal.

[MahendraDani]

@noman2002
I am not able to mock the situation in which the else statement is executed.
Would you please help?

[MahendraDani]

@noman2002
I have tried all possible mocks and I have represented the outputs in the form of a diagram.

Please observe from the diagram that there are only three possible cases when any person tries to login into user portal http://localhost:3000/user:

• With no credentials i.e person clicks login button without entering email and password then they are responded with error toast message Please enter a valid password and email.
• When person is either user,admin or superadmin they are logged into user portal succcessfully.
• When person tries to login with credentials which are not in database then the response is a error toast with message User not found.

Note that all the above cases are already covered in the current tests.

We can observe that there is no other case than this in which control will execute line 54 and 55

What do you think? If there is anything that I missed please help me through.
Thanks

[MahendraDani]

@noman2002 I have tried all possible mocks and I have represented the outputs in the form of a diagram.

Please observe from the diagram that there are only three possible cases when any person tries to login into user portal http://localhost:3000/user:

• With no credentials i.e person clicks login button without entering email and password then they are responded with error toast message Please enter a valid password and email.
• When person is either user,admin or superadmin they are logged into user portal succcessfully.
• When person tries to login with credentials which are not in database then the response is a error toast with message User not found.

Note that all the above cases are already covered in the current tests.

We can observe that there is no other case than this in which control will execute line 54 and 55

What do you think? If there is anything that I missed please help me through. Thanks

@noman2002 Any suggestions?

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[palisadoes]

Unassigning due to inactivity and no related PR

[pateldivyesh1323]

@noman2002, @palisadoes I would like to work on this.

There is no case which will enter into else condition as described by @MahendraDani. Actually that else condition was used in admin login where it used to filter normal users to not enter into admin portal. But in user portal admins can also login. In case if request does not carry any data it will always go to catch block.

[pateldivyesh1323]

I am unassigning myself, this is now up for grabs.

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[shankeleven]

please assign the issue to me, would love to work

[Shashankpantiitbhilai]

I am interested,please assign this to me

[Cioppolo14]

@shankeleven Sorry I missed this earlier! You currently have 2 issues in another repo, so I am going to assign it to @Shashankpantiitbhilai.

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[Cioppolo14]

Unassigning due to inactivity.

[Sauradip07]

Please assign me I want to work on this issue

[Cioppolo14]

@Sauradip07 Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

[gautam-divyanshu]

Please assign me this issue , love to work on it.

[gautam-divyanshu]

Please assign me this issue , love to work on it.
I am working on it.

[karthxk07]

@palisadoes Sir, Is this issue still open and stale? I can work on this.

[shankeleven]

please assign this issue to me @palisadoes @Cioppolo14
would love to work on this

[github-actions]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[Cioppolo14]

Unassigning due to no activity.

[pranshugupta54]

Hey @Cioppolo14, @palisadoes. Is this completed?

Coverage looks 100%