Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage: Create tests for src/components/CheckIn/CheckInWrapper.tsx #1031

Closed
palisadoes opened this issue Nov 5, 2023 · 32 comments
Closed
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

We will need unittests done for all methods, classes and functions found in this file.

Any widgets, components, modals referenced in this file must also have unittests done

PR Acceptance Criteria

@palisadoes palisadoes added the bug Something isn't working label Nov 5, 2023
@palisadoes palisadoes added good first issue Good for newcomers test Testing application and removed bug Something isn't working labels Nov 5, 2023
@duplixx
Copy link
Member

duplixx commented Nov 11, 2023

hey @palisadoes , can you assign me this issue i wanna work on it
Thanks !!

@noman2002
Copy link
Member

@duplixx You already have 2 issues in your name. Please get the PRs merged first, then I'll assign more. As per the rules only 2 issues can be assigned at once.

@duplixx
Copy link
Member

duplixx commented Nov 11, 2023

hey @noman2002 , you can assign me this as my previous PR is merged now!!

@duplixx duplixx removed their assignment Nov 18, 2023
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 29, 2023
@lakshz
Copy link
Contributor

lakshz commented Dec 1, 2023

Please assign this to me.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 2, 2023
@noman2002
Copy link
Member

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@adi790uu
Copy link
Contributor

adi790uu commented Dec 5, 2023

Hey @noman2002 I want to work on this issue!

@punitkr03
Copy link
Contributor

Hey ,I want to work on this, please assign me.

@noman2002
Copy link
Member

@adi790uu You already have 2 issues assigned to you.

@punitkr03
Copy link
Contributor

punitkr03 commented Dec 6, 2023

Het @noman2002, I just found this comment in the test file. If the memory leak is fixed I can uncomment it. Suggestions?
image

@punitkr03
Copy link
Contributor

punitkr03 commented Dec 6, 2023

I tried uncommenting it and the memory leak is still there. I will try to fix that as well.
Update: The issue is with @mui/x-data-grid. However, this issue is fixed in recent release of the package. I tried updating the package but it broke other things. What can be my next steps?

@punitkr03
Copy link
Contributor

@noman2002 Hey, I have been waiting for your input.

@noman2002
Copy link
Member

@aashimawadhwa @EshaanAgg Please answer his queries.

@EshaanAgg
Copy link
Contributor

@punitkr03 I had left the comment to show what the prospective test must look like after the memory leak in broken. The test is not full proof as it hasn't been tested in the wild due to the aforementioned leak.

  • Please first make sure that the memory leak is indeed fixed.
  • If it is so, then you can try writing the tests for the same from a fresh perspective, and see how 100% coverage can be achieved. Use the provided test as reference, and not as a strict format.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 26, 2023
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity and no pull request

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 27, 2023
@DIWAKARKASHYAP
Copy link

@noman2002 I have read the issue. I can solve it. Could you please assign this to me?

@DIWAKARKASHYAP
Copy link

Hello @noman2002 @palisadoes
I am facing an issue. When I run the Talawa-admin develop branch, this happens

talawa.mp4

but the main branch is working fine

@punitkr03
Copy link
Contributor

punitkr03 commented Jan 2, 2024

@DIWAKARKASHYAP You have to run talawa-api either in docker container or manually. So fork talawa-api repo and set it up too. I will recommend using docker.

@DIWAKARKASHYAP
Copy link

DIWAKARKASHYAP commented Jan 2, 2024

I am using docker for talawa api ,
image

image

page is automatically reload

@punitkr03
Copy link
Contributor

Did u set your NODE_ENV in .env file to development?

@DIWAKARKASHYAP
Copy link

yes all variable are setup , the main branch is working properly but develop branch give me this problem

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 14, 2024
@palisadoes
Copy link
Contributor Author

Removing assignment due to inactivity

@ashutuptiwari
Copy link

@palisadoes I'd like to work on this :D

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 15, 2024
@ashutuptiwari
Copy link

ashutuptiwari commented Jan 17, 2024

image
@Cioppolo14
PS: the memory leak is still not fixed

@Cioppolo14
Copy link
Contributor

@ashutuptiwari Please fix the memory leak as part of this issue.

@ashutuptiwari
Copy link

Alright, can you please describe the leak @Cioppolo14

@palisadoes
Copy link
Contributor Author

Alright, can you please describe the leak @Cioppolo14

If you have discovered that it's still there, you should be able to find it and fix it.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jan 29, 2024
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity and/or no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jan 30, 2024
@Anvita0305
Copy link
Contributor

Hello, @noman2002 @Cioppolo14 I would like to work on this issue. Can you please assign it to me? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

No branches or pull requests