Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage: Create tests for src/screens/MemberDetail/MemberDetail.tsx #1028

Closed
palisadoes opened this issue Nov 5, 2023 · 11 comments
Closed
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

We will need unittests done for all methods, classes and functions found in this file.

Any widgets, components, modals referenced in this file must also have unittests done

PR Acceptance Criteria

@palisadoes palisadoes added the bug Something isn't working label Nov 5, 2023
@palisadoes palisadoes added good first issue Good for newcomers test Testing application and removed bug Something isn't working labels Nov 5, 2023
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Nov 16, 2023
@kanhaiya04
Copy link
Contributor

hey @aashimawadhwa , please assign me this.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Nov 21, 2023
@palisadoes
Copy link
Contributor Author

palisadoes commented Nov 21, 2023

@kanhaiya04 Our policy is to assign no more than two issues to each contributor. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

@Gmin2
Copy link
Contributor

Gmin2 commented Nov 30, 2023

I am working on it

@hharshas
Copy link

hharshas commented Dec 6, 2023

Can you assign me this issue @palisadoes I would like to work on this

@noman2002
Copy link
Member

@hharshas We are assigning on first come first serve basis. Please comment on other open issues to get it assigned.

@Gmin2
Copy link
Contributor

Gmin2 commented Dec 6, 2023

Can you assign me this issue @palisadoes I would like to work on this

Hey @hharshas go ahead with this

@Gmin2 Gmin2 removed their assignment Dec 6, 2023
@hharshas hharshas removed their assignment Dec 12, 2023
@bupd
Copy link
Contributor

bupd commented Dec 12, 2023

Hi 👋 @noman2002 I noticed that issue #1028 has been assigned but hasn't seen any activity in the past week. I completely understand that everyone has their own commitments and priorities.

I was wondering if the current assignee is still actively working on the issue. If not, I'd be happy to take it over and contribute to the progress of the project.

Thanks.

@bupd
Copy link
Contributor

bupd commented Dec 15, 2023

We can consider closing this issue.

@bupd bupd removed their assignment Dec 15, 2023
@Cioppolo14
Copy link
Contributor

@bupd @noman2002 Can you clarify what you mean here? Does this issue need to be closed?

@noman2002
Copy link
Member

@Cioppolo14 Yes we can close this as the PR related to this issues is merged. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants