Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of incorrect react-toast notification. #1019

Closed
skbhagat0502 opened this issue Oct 31, 2023 · 1 comment · Fixed by #1053
Closed

Use of incorrect react-toast notification. #1019

skbhagat0502 opened this issue Oct 31, 2023 · 1 comment · Fixed by #1053
Assignees
Labels
bug Something isn't working feature request

Comments

@skbhagat0502
Copy link
Contributor

Describe the bug
There are a lot of place where promise messages is shown as warnings. I think that should be removed with promise messages given by react-toastify.
Like in this image adding the attendee is shown with warning symbol:
Screenshot 2023-11-01 002603
Instead of that it should be like this as shown in the video with the text "Adding the attendee." and when it is added it should be "Attendee added"

2023-11-01.00-35-18.mp4

There are a lot of places where wrong react-toast are used.
image

Expected behavior
A clear and correct react-toastify message should be used in all the places.

Actual behavior
Wrong message patterns are there in lot of places.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional details
Add any other context or screenshots about the feature request here.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@skbhagat0502 skbhagat0502 added the bug Something isn't working label Oct 31, 2023
@skbhagat0502
Copy link
Contributor Author

@palisadoes Please assign me this issue. I will correct all the react-toast messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants