Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit parallel funnel ordering on close timestamps #382

Open
SebastienGllmt opened this issue Jun 6, 2024 · 0 comments
Open

Revisit parallel funnel ordering on close timestamps #382

SebastienGllmt opened this issue Jun 6, 2024 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@SebastienGllmt
Copy link
Contributor

When running parallel funnels, blocks from 2 different chains may have the same timestamp

Currently, Paima Engine will break ties depending on the order the funnels are specified in your config file

However, there are a few things that make this behavior not obvious:

  1. It's not mentioned in our docs
  2. It's not explicitly enforced in the code (this just a result of the way JS internals work with Object.key and YAML.parse)
  3. This tie-breaker logic doesn't just happen when the timestamps are equal - it happens when different chains are fetched from the same getSyncRoundData

This behavior is not immediately obvious to users or developers, so we should make the behavior as obvious as possible and properly document it.

@SebastienGllmt SebastienGllmt added bug Something isn't working documentation Improvements or additions to documentation labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant