Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove do_average_in_cpu, max_average_window, average_window from optimizers.py #905

Merged
merged 2 commits into from
Dec 15, 2016

Conversation

pengli09
Copy link
Contributor

These three parameters have already been moved to model_average. Leaving them here will cause duplicate keys in kwargs.

…imizers.py

These three parameters have already been moved to model_average. Leaving
them here will cause duplicate keys in kwargs
@@ -412,7 +409,6 @@ def settings(batch_size,
args = [
'batch_size', 'learning_rate', 'learning_rate_decay_a',
'learning_rate_decay_b', 'learning_rate_schedule', 'learning_rate_args',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来,这里多了个,
所以导致Paddle格式检查不过。

目前paddle使用pre-commit来做格式检查。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@reyoung reyoung merged commit 638cf8d into PaddlePaddle:develop Dec 15, 2016
@pengli09 pengli09 deleted the fix-model-avg-py-error branch December 20, 2016 08:17
@pengli09 pengli09 restored the fix-model-avg-py-error branch December 20, 2016 08:22
@wangkuiyi wangkuiyi mentioned this pull request Mar 2, 2017
wangxicoding pushed a commit to wangxicoding/Paddle that referenced this pull request Dec 9, 2021
lizexu123 pushed a commit to lizexu123/Paddle that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants