-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate image build for docker-compose #206
Comments
Hi |
Thanks, I've added it at #207 here. Docker Hub pushes are trivial to automate now that docker-compose handles building (simply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The px4flightreview image does not exist until you build it manually, meaning the docker-compose config will not launch until you build the Dockerfile. Combined with a relative lack of documentation, this leads to user confusion.
It would be best to add a
build:
section in the docker-compose configuration, which will automatically build and tag the image when the configuration is run.Side note: have we considered pushing an actual official px4flightreview image to Docker Hub? It may be useful to have.
The text was updated successfully, but these errors were encountered: