Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check tax-unit benefit data (CPS) #115

Closed
Amy-Xu opened this issue Sep 8, 2017 · 8 comments
Closed

Check tax-unit benefit data (CPS) #115

Amy-Xu opened this issue Sep 8, 2017 · 8 comments

Comments

@Amy-Xu
Copy link
Member

Amy-Xu commented Sep 8, 2017

During the development of extrapolation routine for benefit data, Martin spot this SSI imputation error from the tabulation on participants number per tax unit. It would be great if we could put together a checking routine, or a testing script for this dataset. Due to the lack of official tax-unit benefit statistics, I think we could start brainstorming a checking list and then automate the checking process. I imagine this is a job parallel to the development of extrapoation routine and hopefully we could get a draft version done before making UBI analysis available to the public on TB.

To this point, I think

  • program aggregates (benefit & participation)
  • tax unit participation cap

have already proven to be useful and therefore should be included in the list. Would like to hear more suggestions/comments/discussion on this issue.

@martinholmer @MattHJensen @hdoupe @andersonfrailey

@Amy-Xu Amy-Xu changed the title Check tax-unit benefit data in CPS Check tax-unit benefit data (CPS) Sep 8, 2017
@MattHJensen
Copy link
Contributor

I agree that it would be helpful to have an initial version of these tests up and running before we make UBI analysis available to the public on TB.

@andersonfrailey, could you add it to the grand task list and make the sure necessary responsibilities are accounted for?

.

@MattHJensen
Copy link
Contributor

MattHJensen commented Oct 2, 2017

As for the tables themselves, everything from the C-TAM documentation would probably be valuable to start. There are certainly diagnostic histograms that could also be valuable. .

@Amy-Xu
Copy link
Member Author

Amy-Xu commented Oct 2, 2017

@MattHJensen it wouldn't be difficult to generate those decile tables. Is the goal of these tests to make sure all the benefit numbers stay the same over time? What type of histograms would be good for diagnostic purpose? I assume we couldn't compare tax unit distribution with raw CPS distribution directly.

@MattHJensen
Copy link
Contributor

There are a few goals

  • Know exactly when and why results change.
  • Provide up to date tables that summarize the database, allow for diagnostic review, and demonstrate the models capabilities.
  • Provide up to date code for generating useful tables.

@MattHJensen
Copy link
Contributor

What type of histograms would be good for diagnostic purpose?

For example, histograms of participants in a tax unit, like those histograms that helped in the recent SSI diagnostic effort.

@Amy-Xu
Copy link
Member Author

Amy-Xu commented Oct 3, 2017

So if there's no objection or further discussion, I'm about to add a regression test script in taxdata repo. This script will generate 1) decile participation and benefit tables for each program, 2) participation and benefit totals, and 3) tabulation of tax-unit participation. Then the script will compare these tables with the existing versions or official stats if available.

@martinholmer @MattHJensen @hdoupe @andersonfrailey

@MattHJensen
Copy link
Contributor

Thanks Amy. Sounds great.

@Amy-Xu
Copy link
Member Author

Amy-Xu commented Jan 11, 2018

Closing this issue as PR #135 addressed the concerns here.

@Amy-Xu Amy-Xu closed this as completed Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants