Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demographics plotting issues and documentation #77

Closed
rickecon opened this issue Oct 26, 2023 · 2 comments
Closed

Demographics plotting issues and documentation #77

rickecon opened this issue Oct 26, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@rickecon
Copy link
Member

Since updating the mortality rates rho object to allow for time varying mortality rates in PR #73, the plotting functions in demographics.py functions get_fert(), get_mort(), and get_imm_rates() have stopped working. This has caused the documentation to stop building because much of the executable code in the calibration: demographics section depends on those plotting functions. We need to fix those plotting functions.

cc: @jdebacker

@rickecon rickecon added the bug Something isn't working label Oct 26, 2023
@jdebacker
Copy link
Member

jdebacker commented Nov 20, 2023

@rickecon I tested this with my ogusa-dev environment, which has

(ogusa-dev) jason.debacker@JDEBACKER-7 OG-USA % python --version
Python 3.11.6
(ogusa-dev) jason.debacker@JDEBACKER-7 OG-USA % conda list matplotlib
# packages in environment at /Users/jason.debacker/anaconda3/envs/ogusa-dev:
#
# Name                    Version                   Build  Channel
matplotlib                3.8.0           py311h6eed73b_2    conda-forge
matplotlib-base           3.8.0           py311hd316c10_2    conda-forge
matplotlib-inline         0.1.6                    pypi_0    pypi

And I am able to successfully produce plots to the default directory. Code to reproduce:

import ogusa.demographics as demog
demog.get_fert(graph=True)
demog.get_mort(graph=True)
demog.get_imm_rates(graph=True)

If you are having issues, can you share the version of Python and Matplotlib being used (or other packages you think are relevant to the error)?

@jdebacker
Copy link
Member

We moved the demographics module to OG-Core (PR #86 removes it from OG-USA) and these issues have been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants