Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OG-USA new release after 0.5.9? #321

Closed
hdoupe opened this issue Oct 25, 2017 · 5 comments
Closed

OG-USA new release after 0.5.9? #321

hdoupe opened this issue Oct 25, 2017 · 5 comments

Comments

@hdoupe
Copy link
Contributor

hdoupe commented Oct 25, 2017

Do we want to release a new version of OG-USA for TaxBrain reinstatement?

I think that this release would include PR's #305, #308, #311, #312, #313, and #315. One more PR may be necessary to set the path to the PUF file or to take the PUF dataframe as an argument in execute.runner and pass that to Tax-Calculator in get_micro_data.get_calculator.

@PeterDSteinberg @rickecon @PeterDSteinberg

@hdoupe hdoupe changed the title OG-USA new release after 0.5.9 OG-USA new release after 0.5.9? Oct 25, 2017
@PeterDSteinberg
Copy link
Contributor

I am not as familiar with the PRs you listed above @hdoupe . We are also currently working on OG-USA related changes for webapp's issues ospc-org/ospc.org#481 and ospc-org/ospc.org#482 . We hope to wrap those new features up this week for 481 and 482. Maybe deploy after those are addressed? Or two deploys?

@hdoupe
Copy link
Contributor Author

hdoupe commented Oct 25, 2017

Ok, I think we are going to be pretty tight on time if we try to include ospc-org/ospc.org#481 and ospc-org/ospc.org#482 in the next release on Friday. We are on a pretty tight release schedule through the rest of the year. A CPS option and UBI parameters need to be added by the end of the year. So, I'm wary of two things:

  1. Rushing these features in on Friday and running into bugs
  2. Waiting to release until after these features have been merged and then falling behind on our release schedule

It seems to me that the best course of action is to release without OG-USA on Friday and to incorporate it in the next release. This means that it would not be added for about 3 weeks.

@PeterDSteinberg @jdebacker @rickecon @brittainhard @MattHJensen what are your thoughts?

@PeterDSteinberg
Copy link
Contributor

@hdoupe I was just about to email you. I spoke with @brittainhard and agree we should not try to get 481 and 482 fixed by Friday. Also Brittain and I need to rebase the work we have done for 481 on your ospc-org/ospc.org#710 . We can go ahead and branch off that Policybrain PR 710 then when 710 is merged we can pull master into our fixes for 481, 482. That way we can get it ready for merge by Friday but have 3 weeks for testing on test app.

@hdoupe
Copy link
Contributor Author

hdoupe commented Oct 25, 2017

@PeterDSteinberg This sounds good to me. Sorry, I should have looped you in on ospc-org/ospc.org#710. Let me know if there is anything that I can do to help with your changes, especially when related to 710.

@hdoupe
Copy link
Contributor Author

hdoupe commented Oct 30, 2017

I think this has been resolved. Closing #321

@hdoupe hdoupe closed this as completed Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants