Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency in the relation to length or size in arguments of generators #965

Open
amirDahari1 opened this issue Jun 5, 2024 · 0 comments
Labels
api PR tag for breaking changes

Comments

@amirDahari1
Copy link
Contributor

amirDahari1 commented Jun 5, 2024

It would be more convenient if all generators features would be either relative to the lengthscale of the image (shape.mean()) or to the size of the image (np.prod(shape)).
For example, the blobiness argument in blobs is relative to shape.mean() with the sigma of the gaussian blur defined by np.mean(shape) / (40 * blobiness), while ncells in voronoi_edges is relative to the size of the image (in order to get the same size of cells in different images, we need to multiply the number of cells by the size of the image and not by the lengthscale).

I think it would make more sense to have all arguments relative to the lengthscale, so that the comparison between 2D and 3D would be easier and straightforward.

@jgostick jgostick added the api PR tag for breaking changes label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api PR tag for breaking changes
Projects
None yet
Development

No branches or pull requests

2 participants