Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running non-janis workflows with the assistant #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

illusional
Copy link
Member

We sort of suggest it would be possible in the talk, and I always thought it shouldn't be too technically hard to implement (as we convert the workflow to CWL / WDL anyway).

This PR tests packed CWL workflows with cwltool which WORKS!

There are a number of things that haven't been implemented yet:

  • Type of workflow spec (CWL / WDL) - this changes which engines are compatible. The assistant was designed with this, and knows which specs each engine can support.
  • Output collection (Janis has previously inferred from the outputs from the task description), we would need to change the way this works (and you'd lose the fancy janis output naming)
  • Required a PACKED workflow. We could very theoretically pack it for the user.
  • Inputs are expected to be already formatted for the engine, include the class: File annotation for cwltool, or only json formatted for Cromwell.
  • CWL support for cromwell is unclear, it would be good to clear up how to submit workflows again to Cromwell.
  • + I'm sure many more things.

But this PR shows that Janis can be modular and you could jump out (or IN) at different stages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant