Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGEPRO-GUI/CoreLib Versioning with AGEPRO Calculation Engine #20

Closed
efletcherPIFSC opened this issue Dec 19, 2024 · 1 comment
Closed
Assignees
Labels
wontfix This will not be worked on

Comments

@efletcherPIFSC
Copy link
Collaborator

Next updates for AGEPRO-GUI/CoreLib will contain

Changes to AuxiliaryOutputFlag(SummaryStockFlag) will update the AGEPRO Input File format to AGEPRO VERSION 4.25 (PIFSCstockassessments/AGEPRO#11), which will be rolled in a future AGEPRO Calculation Engine release.

GUI/Calculation Engine Version Disparity

The 4.3.X GUI version is a "revamp" from the NOAA Fisheries Toolbox GUI based 4.2.X AGEPRO GUI, but uses version 4.2 of the AGEPRO Calculation Engine

As of December 2024, the current version of AGEPRO-GUI is version 4.3.5, which uses AGEPRO VERSION 4.0 input data files. AGEPRO-GUI releases is listed on PIFSCstockassessments GitHub and NOAA Fisheries Integrated Toolbox. AGEPRO's NOAA FIT page is tagged with the AGEPRO-GUI version v4.3.5

https://github.com/PIFSCstockassessments/AGEPRO-GUI/releases
https://noaa-fisheries-integrated-toolbox.github.io/AGEPRO

Solutions

To fix the version disparity (and confusion) between GUI and calculation engine versions, I believe that next version release should emphasize AGEPRO Calculation Engine Version but also maintain a its own version number.

The following are what the AGEPRO-GUI versioning scheme will be:

  • <CalcVer>-<GUIver> : 4.25-4.3.6
    • This keeps the AGEPRO-GUI versioning scheme, but the combining the CalcVer and GUIver strings into one makes it comfusing to read
  • <CalcVer>-gui<GUI_Release> and <CalcVer>-glib<CoreLib_Release>: 4.25-gui6 4.25-glib6
    • Its to the point ("It is the gui ver of Calc"), but introduces a new versioning scheme for GUI releases. If "4.3.6" was the next GUI release, then it would numbered as 4.25-gui6. CoreLib can be labeled similarly, but to should be numbered as the same as the GUI release (in this example, 4.25-glib6).
@efletcherPIFSC efletcherPIFSC self-assigned this Dec 19, 2024
@efletcherPIFSC
Copy link
Collaborator Author

After some thought, keeping AGEPRO-GUI current sematic versioning format is sufficient.

@efletcherPIFSC efletcherPIFSC added the wontfix This will not be worked on label Dec 19, 2024
efletcherPIFSC added a commit to PIFSCstockassessments/AGEPRO-CoreLib that referenced this issue Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant