Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: JP name fixes #10119

Merged
merged 2 commits into from
Oct 16, 2023
Merged

GameDB: JP name fixes #10119

merged 2 commits into from
Oct 16, 2023

Conversation

TellowKrinkle
Copy link
Member

Description of Changes

  • Adjusts all final fantasy games to have matching names
  • Fixes use of non-English names in pause menu overlay (imgui font support is terrible, so using non-English names results in ???s)

Rationale behind Changes

No one likes it when their game is ???????

Suggested Testing Steps

  • Refresh and look at your Final Fantasy game collection
  • View games from pause menu

@stenzek
Copy link
Contributor

stenzek commented Oct 16, 2023

You'll probably need to do this in VMManager::ReportGameChangeToHost() as well. Otherwise, it'll only use the English title when you open the pause menu with no game started, not if you launch the game from Big Picture.

@TellowKrinkle
Copy link
Member Author

Should be fixed now

Copy link
Contributor

@stenzek stenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, untested.

@TellowKrinkle TellowKrinkle merged commit b28c11c into PCSX2:master Oct 16, 2023
13 checks passed
@TellowKrinkle TellowKrinkle deleted the GameDBJPFixes branch October 16, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants