From 2a1e8ad034e696b161b581abee5f6668464a5380 Mon Sep 17 00:00:00 2001 From: Ziemas Date: Tue, 10 Oct 2023 10:12:11 +0200 Subject: [PATCH] SPU2: Delete stupid comment What "volume pump" is this even reffering to? --- pcsx2/SPU2/Mixer.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/pcsx2/SPU2/Mixer.cpp b/pcsx2/SPU2/Mixer.cpp index 13db70eb85a339..d3663df51cf5d3 100644 --- a/pcsx2/SPU2/Mixer.cpp +++ b/pcsx2/SPU2/Mixer.cpp @@ -661,15 +661,9 @@ __forceinline Out.Right = ApplyVolume(Out.Right, Cores[1].MasterVol.Right.Value); } - // Final Clamp! - // Like any good audio system, the PS2 pumps the volume and incurs some distortion in its - // output, giving us a nice thumpy sound at times. So we add 1 above (2x volume pump) and - // then clamp it all here. - - // Edit: I'm sorry Jake, but I know of no good audio system that arbitrary distorts and clips - // output by design. - // Good thing though that this code gets the volume exactly right, as per tests :) Out = DCFilter(Out); + + // Final clamp, take care not to exceed 16 bits from here on Out = clamp_mix(Out); SndBuffer::Write(StereoOut16(Out));