Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases and tags for MIP tables #207

Open
ehogan opened this issue Aug 2, 2018 · 9 comments
Open

Releases and tags for MIP tables #207

ehogan opened this issue Aug 2, 2018 · 9 comments

Comments

@ehogan
Copy link
Contributor

ehogan commented Aug 2, 2018

I'm having some trouble understanding the release numbers / tags for the MIP tables. The February 15 release has a tag 6.0.21 and a related comment of CMIP6_CVs-6.2.0.11/DREQ-01.00.21/CMOR-3.3.1. I'm guessing the 6 comes from the CVs (although this doesn't define exactly which version of the CVs were used in this release) and the 21 comes from the data request, but where does the 0 come from? Also, more recent releases do not follow this system, nor do they have a comment like the one above, so it's not clear which version of the data request was used.

It looks like both 6.2.10.0 and 6.2.11.2 use version 01.00.27 of the data request. So if someone says "I'm using version 01.00.27 of the MIP tables", how can we be sure which version out of 6.2.10.0 and 6.2.11.2 they are actually using?

@doutriaux1
Copy link
Contributor

@ehogan as far as I understand drs and CV come from 2 sources (with some overlap I'm sure) hrnce the two numbers. @taylor13 and @ducrack1 can comment on this, also there is a "document" for this see: https://docs.google.com/document/d/1os9rZ11U0ajY7F8FWtgU4B49KcB59aFlBVGfLC4ahXs/edit

@taylor13
Copy link
Collaborator

taylor13 commented Aug 2, 2018

I think the relevant document is https://goo.gl/86C4ZB . Look at section 3 under "CMOR and PrePARE" and "CMOR Tables".

@taylor13
Copy link
Collaborator

taylor13 commented Aug 2, 2018

The recent CMOR Table labeling has not followed the specifications given in https://goo.gl/86C4ZB . Moreover, we messed up when we corrected information coming from the data request, rather than asking Martin to correct the data request. We made a correction (and requested Martin make the correction in the next version of the data request; see cmip6dr/CMIP6_DataRequest_VariableDefinitions#340). According to the labeling rules, because both of the recent CMOR table releases are based on the same CVs and same data request, the CMOR table version number should not change. In the future, we shouldn't make edits to the CMOR tables; we should wait for corrections either to the CVs or in the data request before updating CMOR tables.

Following the rules, here is what the version numbers should be:

Incorrect Label                Correct Label
6.2.8.23                             6.2.24
6.2.10.0                             6.3.27
6.2.11.2                             6.3.27

Note that a change to the 2nd digit indicates a significant change to the CVs (addition/modifications to source_id and institution_id are considered "insignificant").
The last two digits (e.g., 27) indicate the data request version.

I think we should destroy the most recent release (because we didn't follow the correct procedure), and we should relabel the 2 previous releases as 6.2.24 and 6.3.27.

Also we need to include comments like CMIP6_CVs-6.2.0.11/DREQ-01.00.21/CMOR-3.3.1.

@wachsylon
Copy link

Hi,
one question:
How can I access the git release note? I need the information about the three versions:

CMIP6_CVs-6.2.0.5/DREQ-01.00.11/CMOR-3.2.4

For old versions, I get it by git tag -l -n probably from a commit:

git tag -l -n
6.0.11          CMIP6_CVs-6.2.0.5/DREQ-01.00.11/CMOR-3.2.4

But for recent versions, the only output from that command is:
6.9.32 Merge pull request #311 from PCMDI/01.00.32

Best and thanks for help,
Fabi

@wachsylon
Copy link

@mauzey1
Do you have an idea? When I said

access the release note

I meant with git or a program.

I need to check CMIP6 data with tables corresponding to the data's data_specs_version. I know that I could browse through the commit history but I thought that one reason for the release note is to simplify that exercise.

@mauzey1
Copy link
Collaborator

mauzey1 commented Jun 16, 2020

@taylor13 @durack1 @wachsylon It looks like I will need to edit the tag messages manually using git. I will try this with the latest release. If successful, I will do it to previous releases.

@durack1
Copy link
Contributor

durack1 commented Jun 16, 2020

@mauzey1 just FYI, I wrote some code to clean up the CMIP6_CVs tags many moons ago, importantly this code preserves the existing timestamps.

This would also be a method of cleaning up rogue/obsolete tags if that was required

@mauzey1
Copy link
Collaborator

mauzey1 commented Jun 16, 2020

@durack1 Thanks for the script. I have cleaned up the release tags for cmip6-cmor-tables. They should all now have the same tag message format. https://github.com/PCMDI/cmip6-cmor-tables/releases

@durack1
Copy link
Contributor

durack1 commented Jul 3, 2024

@mauzey1 it seems we have moved a fair way from the current 6.9.33 release (identifier CMIP6_CVs-6.2.54.5/DREQ-01.00.33/CMOR-3.6.0) as we now have CMOR 3.8.0 (almost 3.9.0), CMIP6_CVs 6.2.58.68, with the DREQ static.

Should we automate the update of versions as CMIP6_CVs change? Note there is not an expectation that this will be happening a lot, but we do expect a couple of additional changes before the project is sunset and edits cease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants